-
Notifications
You must be signed in to change notification settings - Fork 375
refactor: enhance logging and error handling in scheduler functions #1144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: haitwang-cloud The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d1791fb
to
47f0a21
Compare
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
@chaunceyjiang @lengrongfu @archlitchi @wawa0210 PTAL,tks |
pkg/scheduler/scheduler.go
Outdated
} | ||
d.Device.MigUsage.UsageList[Instance].InUse = true | ||
klog.V(5).Infoln("add mig usage", d.Device.MigUsage, "template=", d.Device.MigTemplate, "uuid=", d.Device.ID) | ||
klog.V(5).InfoS("MIG device allocated", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use 4 level.
@lengrongfu Addressed your comment, PTAL again |
Signed-off-by: haitwang-cloud <[email protected]>
fba2592
to
310e396
Compare
What type of PR is this?
/kind flake
What this PR does / why we need it:
This PR mainly optimizes and standardizes the logging in scheduler.go:
Unifies and adjusts log levels for better readability.
Adds structured logs with more details (such as pod, node, and device information).
Improves error log context to make troubleshooting easier.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
No