Skip to content

Conversation

haitwang-cloud
Copy link
Contributor

@haitwang-cloud haitwang-cloud commented Jun 24, 2025

What type of PR is this?
/kind flake

What this PR does / why we need it:

This PR mainly optimizes and standardizes the logging in scheduler.go:

Unifies and adjusts log levels for better readability.
Adds structured logs with more details (such as pod, node, and device information).
Improves error log context to make troubleshooting easier.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
No

@hami-robot
Copy link
Contributor

hami-robot bot commented Jun 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haitwang-cloud
Once this PR has been reviewed and has the lgtm label, please assign archlitchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 50.76923% with 32 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/scheduler/scheduler.go 50.76% 32 Missing ⚠️
Flag Coverage Δ
unittests 54.08% <50.76%> (+1.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/scheduler/scheduler.go 50.46% <50.76%> (+4.55%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haitwang-cloud
Copy link
Contributor Author

haitwang-cloud commented Jun 25, 2025

}
d.Device.MigUsage.UsageList[Instance].InUse = true
klog.V(5).Infoln("add mig usage", d.Device.MigUsage, "template=", d.Device.MigTemplate, "uuid=", d.Device.ID)
klog.V(5).InfoS("MIG device allocated",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use 4 level.

@haitwang-cloud
Copy link
Contributor Author

@lengrongfu Addressed your comment, PTAL again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants