Skip to content

Fix character reference parsing #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix character reference parsing #569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions spec/entities_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,34 @@ describe("XMLParser Entities", function() {
expect(result).toEqual(expected);
});

it("should parse different entity character reference variants", function() {
const xmlData = `<?xml version="1.0"?>
<tests>
<test>&lt;</test>
<test>&#60;</test>
<test>&#060;</test>
<test>&#0060;</test>
<test>&#x3C;</test>
<test>&#x03C;</test>
<test>&#x003C;</test>
<test>&#x3c;</test>
<test>&#x03c;</test>
<test>&#x003c;</test>
</tests>`;

const expected = {
"?xml": "",
"tests": {
"test": ["<", "<", "<", "<", "<", "<", "<", "<", "<", "<"]
}
};

const parser = new XMLParser();
let result = parser.parse(xmlData, true);

expect(result).toEqual(expected);
});

it("should parse XML with DOCTYPE without internal DTD", function() {
const xmlData = "<?xml version='1.0' standalone='no'?><!DOCTYPE svg PUBLIC \"-//W3C//DTD SVG 1.1//EN\" \"http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd\" ><svg><metadata>test</metadata></svg>";
const expected = {
Expand Down
36 changes: 18 additions & 18 deletions src/xmlparser/OrderedObjParser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,26 +20,26 @@ class OrderedObjParser{
this.tagsNodeStack = [];
this.docTypeEntities = {};
this.lastEntities = {
"apos" : { regex: /&(apos|#39|#x27);/g, val : "'"},
"gt" : { regex: /&(gt|#62|#x3E);/g, val : ">"},
"lt" : { regex: /&(lt|#60|#x3C);/g, val : "<"},
"quot" : { regex: /&(quot|#34|#x22);/g, val : "\""},
"apos" : { regex: /&(apos|#0*39|#x0*27);/gi, val : "'"},
"gt" : { regex: /&(gt|#0*62|#x0*3E);/gi, val : ">"},
"lt" : { regex: /&(lt|#0*60|#x0*3C);/gi, val : "<"},
"quot" : { regex: /&(quot|#0*34|#x0*22);/gi, val : "\""},
};
this.ampEntity = { regex: /&(amp|#38|#x26);/g, val : "&"};
this.ampEntity = { regex: /&(amp|#0*38|#x0*26);/gi, val : "&"};
this.htmlEntities = {
"space": { regex: /&(nbsp|#160);/g, val: " " },
// "lt" : { regex: /&(lt|#60);/g, val: "<" },
// "gt" : { regex: /&(gt|#62);/g, val: ">" },
// "amp" : { regex: /&(amp|#38);/g, val: "&" },
// "quot" : { regex: /&(quot|#34);/g, val: "\"" },
// "apos" : { regex: /&(apos|#39);/g, val: "'" },
"cent" : { regex: /&(cent|#162);/g, val: "¢" },
"pound" : { regex: /&(pound|#163);/g, val: "£" },
"yen" : { regex: /&(yen|#165);/g, val: "¥" },
"euro" : { regex: /&(euro|#8364);/g, val: "€" },
"copyright" : { regex: /&(copy|#169);/g, val: "©" },
"reg" : { regex: /&(reg|#174);/g, val: "®" },
"inr" : { regex: /&(inr|#8377);/g, val: "₹" },
"space": { regex: /&(nbsp|#0*160);/gi, val: " " },
// "lt" : { regex: /&(lt|#0*60);/gi, val: "<" },
// "gt" : { regex: /&(gt|#0*62);/gi, val: ">" },
// "amp" : { regex: /&(amp|#0*38);/gi, val: "&" },
// "quot" : { regex: /&(quot|#0*34);/gi, val: "\"" },
// "apos" : { regex: /&(apos|#0*39);/gi, val: "'" },
"cent" : { regex: /&(cent|#0*162);/gi, val: "¢" },
"pound" : { regex: /&(pound|#0*163);/gi, val: "£" },
"yen" : { regex: /&(yen|#0*165);/gi, val: "¥" },
"euro" : { regex: /&(euro|#0*8364);/gi, val: "€" },
"copyright" : { regex: /&(copy|#0*169);/gi, val: "©" },
"reg" : { regex: /&(reg|#0*174);/gi, val: "®" },
"inr" : { regex: /&(inr|#0*8377);/gi, val: "₹" },
};
this.addExternalEntities = addExternalEntities;
this.parseXml = parseXml;
Expand Down