Skip to content

Conversation

@noramibu
Copy link
Contributor

@noramibu noramibu commented Sep 30, 2025

Type of change

  • New feature

Description

Added Attribute Swap module under combat category

Related issues

Solves #5031 (and duplicates of it #5076 #5531 #5663 #5689 #5720 #5804 )

How Has This Been Tested?

First zombie killed without attribute swapping and second zombie killed with swapping attributes (aka breach swapping)
https://www.youtube.com/watch?v=2WFyUL7tvAI

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@noramibu noramibu marked this pull request as draft November 5, 2025 08:27
@noramibu
Copy link
Contributor Author

noramibu commented Nov 5, 2025

I will update module on 1.22 with automatic mode & other item supports

@noramibu
Copy link
Contributor Author

added a smart mode for attribute swapping which checks if target is burning, has armor etc.

https://youtu.be/vyYVFNm8F9Y

@noramibu noramibu requested a review from crosby-moe December 16, 2025 17:47
- added regular mace
- created a seperate group for mace options,
- renamed smart settings group to swapping options and merged with enchant options
- a bit of refactoring & optimization for loops
@noramibu
Copy link
Contributor Author

forgot to consider sharpness for regular mobs and players & smite for undeads.

Also can't figure out how to attribute swap with spears so i didn't write anything specific to spears for now. If anyone is able to help for it or explain it, i would really like it ^^

- enchants are categorized
- sword enchants for specific mobs added
- impaling (trident) added for aqua mobs
- fire aspect enchant now checks for fire resistance & fire protection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants