Fix Tests: Reduce to 0 MeteoFranceClient.RETRY_DELAY_SEC #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting for nothing Signed-off-by: ATTY Lionel <[email protected]>
|
Bonjour, |
|
Bonjour, Merci pour votre contribution. Par défaut les workflows sont déclenchés par les maintainers. Je viens de les lancer. |
|
Parfait !
|
|
On devrait embarquer ça dans la nouvelle version que l'on publiera en début de semaine prochaine. Merci pour cette contribution efficace ! |
De rien, je regarderai d'ici là si je peux adresser quelques |
GratienDSX
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently Unit tests (via Tox in CI) take around 20 seconds for nothing:
With this fix, we can drastically reduce this timing (in local dev):
and around 2s in Github CI:
Have you done?
- [ ] Update documentation- [ ] Update changelog