Skip to content

[WIP] Proper stream parsing and animations in glvis-js #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 56 commits into
base: master
Choose a base branch
from
Open

[WIP] Proper stream parsing and animations in glvis-js #340

wants to merge 56 commits into from

Conversation

najlkin
Copy link
Contributor

@najlkin najlkin commented May 31, 2025

This PR unifies handling of streams in JS and glvis app to enable all stream commands, resolving #315. Moreover, it introduces animations, i.e., time series of solutions.

↪️ dependencies:

najlkin added 30 commits May 2, 2025 13:12
@najlkin
Fixed the order of source files in Makefile.
38b5b22
@najlkin
Separated script control functions.
360ca25
@najlkin
Introduced Window structure.
a7b9c58
@najlkin
Removed shared Window structure from visualization scenes.
8b9a8b7
@najlkin
Moved script functions to ScriptController making Window static.
a0e70ad
@najlkin
Moved visualization routines to Window and eliminated global cmd-line…
8ed454a 
… options.
@najlkin
Moved scene updating methods to Window.
791cb7d
@najlkin
Updated aux_js.cpp.
473d146
@najlkin
Unified GLVisInitVis() and aux_js.
f2286e3
@najlkin
Changed plain pointers to std unique in Window.
503039b
@najlkin
Included GLVisCommand in Window and made static a few other variables…
c9df9fb 
… in aux_vis.cpp.
@najlkin
Made locscene local.
e2e01bb
@najlkin
Made a few thread-local vis scenes local.
456eb3d
@najlkin
Fixed setting of attributes from script commands.
4b1ff38
@najlkin
Fixed default number padding digits.
44f214f
@najlkin
Reworked script commands adding console help.
8f74350
@najlkin
Fixed double free.
b021552
@najlkin
Changed streams to commands list.
7323f02
@najlkin
Fixed confused fix_elem_orient and save_coloring in stream_reader.
3d658d8
@najlkin
Unified loading of solutions from stream.
25bccc9
@najlkin
Changed StreamReader to commands list.
4510663
@najlkin
Fixed script handling of data coll meshes and improved code safety fo…
2df9cc9 
…r commands enums.
@najlkin
Unified handling of solutions in streams.
94add8b
@najlkin
Added handling of keys if bundled with data.
b2ffa5a
@najlkin
Made command lists thread-safe.
9f9502d
@najlkin
Cosmetic change of command lists.
6c568f3
@najlkin
Minor debugging log change.
b880ffc
@najlkin
Changed init_nodes to unique_ptr.
ced295e
@najlkin
Fixed thread-locality of the script controller.
8687102
@najlkin
Cosmetic change of commands initialization.
eebcea9
najlkin and others added 25 commits May 12, 2025 09:50
@najlkin
Fixed the order of deletion for cleaner cleanup.
6949909
@najlkin
Moved ownership of SdlWindow to Window and removed GetAppWindow() uses.
bcd8fcb
@najlkin
Moved assignment of SdlWindow in VisualizationScene from Init to cons…
3b91045 
…tructor.
@najlkin
Fix of handling failed window creation.
21ab520
@najlkin
Fixed canvas id in sdl.cpp.
20ec3f8
@najlkin
Fixed definition of GLWindow in aux_js.
2a02262
@najlkin
Fixed dereferencing of window in aux_js.
cf1bb1e
@najlkin
Revert "Fixed canvas id in sdl.cpp."
171ed0f 
This reverts commit 20ec3f8.
@najlkin
Revert "Fixed definition of GLWindow in aux_js."
54df563 
This reverts commit 2a02262.
@najlkin
Fixed typo in NOTICE.
b9e80d1
@najlkin
Guarded GL2PS for emscripten.
6919572
@najlkin
Guarded threads for emscripten.
818b538
@najlkin
Fixed aux_vis for emscripten.
a44d2af
@najlkin
Fixed include in script controller.
130c59b
@najlkin
Fixed window for emscripten.
01fa33a
@najlkin
Removed script controller from glvis-js compilation.
caa662a
@najlkin
Fixed window title default value.
c30e836
@justinlaughlin
Trying to update display
9a30736
@najlkin
Enabled compilation threads.cpp.
dba04e9
@najlkin
Removed unreachable code.
e08c703
@najlkin
Refactored communication_thread.
2d2c6fc
@najlkin
Added non-multithreaded stream commands execution for JS.
337c27a
@najlkin
Fixed stream collection construction.
2de3292
@najlkin
A try to fix stream collection constructor.
3df9a8d
@najlkin
Fixed stream collection construction.
d73bf98
@najlkin najlkin linked an issue May 31, 2025 that may be closed by this pull request
Stream commands unavailable in glvis-js #315
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@najlkin najlkin

@justinlaughlin justinlaughlin

Labels
JS WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stream commands unavailable in glvis-js
2 participants
@najlkin @justinlaughlin