-
Notifications
You must be signed in to change notification settings - Fork 17
Fc_1825_1826_av #2785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AnneV-Learn
wants to merge
18
commits into
master
Choose a base branch
from
fc_1825_1826_av
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fc_1825_1826_av #2785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not update Notes field during propagation if the record notes already includes the propagation notes text
Do not propogate a note if that note txr already exits on the CSV entry record
Correction after first testing
Check that record has Notes before offering propagation of Notes
Delete session parameters for POB propagation when new session or change of county
Updates are #1790 deployed
Update calculation of Previous and Next List Entry buttons to account for current record no longer being in the Error or Warning List as it has been accepted or edited
Add change to resolve issue #1825
If the record is not edited the propagation options entry can only be propagated up to the file level.
Attempts to sort Testing log issues R30 and R50
Attempts to sort Testing log issues R30 and R50
includes some AEV comments that need to be removed
Remove use of session param propagation_scope as not required
… not already exist Only offer propagation to Collection level if Propagation record does not already exist. Propagate Notes in the pre_validator even if the exact same note already exists.
Correction to code for checking if propagation record already exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue #1825 and #1826