Skip to content

Conversation

shubham7109
Copy link
Collaborator

Description

PR to add a new Kotlin sample "Style point with distance composite scene symbol" in Scenes category.

Links and Data

Sample issue: kotlin/issues/6563

  • a vTest Job for this PR has been run

@shubham7109 shubham7109 self-assigned this Sep 24, 2025
@shubham7109 shubham7109 added the New sample New Kotlin sample using ArcGIS Maps SDK label Sep 24, 2025
@gunt0001 gunt0001 self-requested a review September 25, 2025 14:10
Copy link
Collaborator

@gunt0001 gunt0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubham7109 - implementation looks good, nice work. I did some ad-hoc testing and noticed that the app crashes/freezes every time I rotate the screen. Could you test this on your end.

@shubham7109
Copy link
Collaborator Author

shubham7109 commented Sep 25, 2025

@gunt0001 Nice catch, took me some thinking to unravel the behavior:

noticed that the app crashes/freezes every time I rotate the screen

Turns out the OrbitGeoElementCameraController will trigger a crash if the geoElement the controller is orbiting is not part of the visible graphics overlay of the SceneView. On rotation, previous graphics overlay containing the plane graphic is replaced with a new one, which causes the controller to trigger a crash.

Added some improvements to dispose of the old controller, and create a new controller for each lifecycle keeping the graphic overlay displayed up-to-date with the orbit controller provided to the SceneView. (Using GlobeCameraController as the default fallback.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New sample New Kotlin sample using ArcGIS Maps SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants