Skip to content

Commit bd1e49c

Browse files
authored
Merge pull request #91 from zivid/2024-08-06-update-csharp-samples
Nail down transformation matrix convention
2 parents 6b444f4 + c8f438a commit bd1e49c

File tree

5 files changed

+18
-18
lines changed

5 files changed

+18
-18
lines changed

source/Applications/Advanced/ROIBoxViaArucoMarker/ROIBoxViaArucoMarker.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,12 @@ static int Main()
8181
}
8282

8383
Console.WriteLine("Estimating pose of detected ArUco marker");
84-
var transformCameraToMarker = new Zivid.NET.Matrix4x4(detectionResult.DetectedMarkers()[0].Pose().ToMatrix());
84+
var cameraToMarkerTransform = new Zivid.NET.Matrix4x4(detectionResult.DetectedMarkers()[0].Pose().ToMatrix());
8585

8686
Console.WriteLine("Transforming the ROI base frame points to the camera frame");
8787
var roiPointsInCameraFrame = TransformPoints(
8888
new List<Zivid.NET.PointXYZ> { pointOInCheckerboardFrame, pointAInCheckerboardFrame, pointBInCheckerboardFrame },
89-
transformCameraToMarker);
89+
cameraToMarkerTransform);
9090

9191
Console.WriteLine("Setting the ROI");
9292
settings.RegionOfInterest.Box.Enabled = true;

source/Applications/Advanced/ROIBoxViaCheckerboard/ROIBoxViaCheckerboard.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,12 @@ static int Main()
6969

7070
Console.WriteLine("Detecting and estimating pose of the Zivid checkerboard in the camera frame");
7171
var detectionResult = Detector.DetectCalibrationBoard(originalFrame);
72-
var transformCameraToCheckerboard = new Zivid.NET.Matrix4x4(detectionResult.Pose().ToMatrix());
72+
var cameraToCheckerboardTransform = new Zivid.NET.Matrix4x4(detectionResult.Pose().ToMatrix());
7373

7474
Console.WriteLine("Transforming the ROI base frame points to the camera frame");
7575
var roiPointsInCameraFrame = TransformPoints(
7676
new List<Zivid.NET.PointXYZ> { pointOInCheckerboardFrame, pointAInCheckerboardFrame, pointBInCheckerboardFrame },
77-
transformCameraToCheckerboard);
77+
cameraToCheckerboardTransform);
7878

7979
Console.WriteLine("Setting the ROI");
8080
settings.RegionOfInterest.Box.Enabled = true;

source/Applications/Advanced/TransformPointCloudFromMillimetersToMeters/TransformPointCloudFromMillimetersToMeters.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ static int Main()
2020
var frame = new Zivid.NET.Frame(dataFile);
2121
var pointCloud = frame.PointCloud;
2222

23-
var transformMillimetersToMeters =
23+
var millimetersToMetersTransform =
2424
new float[,] { { 0.001F, 0, 0, 0 }, { 0, 0.001F, 0, 0 }, { 0, 0, 0.001F, 0 }, { 0, 0, 0, 1 } };
2525

2626
Console.WriteLine("Transforming point cloud from mm to m");
27-
pointCloud.Transform(transformMillimetersToMeters);
27+
pointCloud.Transform(millimetersToMetersTransform);
2828

2929
var transformedFile = "FrameInMeters.zdf";
3030
Console.WriteLine("Saving frame to file: " + transformedFile);

source/Applications/Advanced/TransformPointCloudViaArucoMarker/TransformPointCloudViaArucoMarker.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,19 +30,19 @@ static int Main()
3030
var detectionResult = Detector.DetectMarkers(frame, markerId, markerDictionary);
3131

3232
Console.WriteLine("Estimating pose of detected ArUco marker");
33-
var transformCameraToMarker = new Zivid.NET.Matrix4x4(detectionResult.DetectedMarkers()[0].Pose().ToMatrix());
33+
var cameraToMarkerTransform = new Zivid.NET.Matrix4x4(detectionResult.DetectedMarkers()[0].Pose().ToMatrix());
3434
Console.WriteLine("ArUco marker pose in camera frame:");
35-
Console.WriteLine(transformCameraToMarker);
35+
Console.WriteLine(cameraToMarkerTransform);
3636
Console.WriteLine("Camera pose in ArUco marker frame:");
37-
var transformMarkerToCamera = transformCameraToMarker.Inverse();
38-
Console.WriteLine(transformMarkerToCamera);
37+
var markerToCameraTransform = cameraToMarkerTransform.Inverse();
38+
Console.WriteLine(markerToCameraTransform);
3939

4040
var transformFile = "ArUcoMarkerToCameraTransform.yaml";
4141
Console.WriteLine("Saving a YAML file with Inverted ArUco marker pose to file: " + transformFile);
42-
transformMarkerToCamera.Save(transformFile);
42+
markerToCameraTransform.Save(transformFile);
4343

4444
Console.WriteLine("Transforming point cloud from camera frame to ArUco marker frame");
45-
pointCloud.Transform(transformMarkerToCamera);
45+
pointCloud.Transform(markerToCameraTransform);
4646

4747
var arucoMarkerTransformedFile = "CalibrationBoardInArucoMarkerOrigin.zdf";
4848
Console.WriteLine("Saving transformed point cloud to file: " + arucoMarkerTransformedFile);

source/Applications/Advanced/TransformPointCloudViaCheckerboard/TransformPointCloudViaCheckerboard.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,18 @@ static int Main()
2424

2525
Console.WriteLine("Detecting and estimating pose of the Zivid checkerboard in the camera frame");
2626
var detectionResult = Detector.DetectCalibrationBoard(frame);
27-
var transformCameraToCheckerboard = new Zivid.NET.Matrix4x4(detectionResult.Pose().ToMatrix());
28-
Console.WriteLine(transformCameraToCheckerboard);
27+
var cameraToCheckerboardTransform = new Zivid.NET.Matrix4x4(detectionResult.Pose().ToMatrix());
28+
Console.WriteLine(cameraToCheckerboardTransform);
2929
Console.WriteLine("Camera pose in checkerboard frame:");
30-
var transformCheckerboardToCamera = transformCameraToCheckerboard.Inverse();
31-
Console.WriteLine(transformCheckerboardToCamera);
30+
var checkerboardToCameraTransform = cameraToCheckerboardTransform.Inverse();
31+
Console.WriteLine(checkerboardToCameraTransform);
3232

3333
var transformFile = "CheckerboardToCameraTransform.yaml";
3434
Console.WriteLine("Saving a YAML file with Inverted checkerboard pose to file: " + transformFile);
35-
transformCheckerboardToCamera.Save(transformFile);
35+
checkerboardToCameraTransform.Save(transformFile);
3636

3737
Console.WriteLine("Transforming point cloud from camera frame to Checkerboard frame");
38-
pointCloud.Transform(transformCheckerboardToCamera);
38+
pointCloud.Transform(checkerboardToCameraTransform);
3939

4040
var checkerboardTransformedFile = "CalibrationBoardInCheckerboardOrigin.zdf";
4141
Console.WriteLine("Saving transformed point cloud to file: " + checkerboardTransformedFile);

0 commit comments

Comments
 (0)