Skip to content

Commit a75bbac

Browse files
committed
Revert "[jaeger-v2] Add HotROD integration test for jaeger-v2 (jaegertracing#6138)"
This reverts commit 2d74619.
1 parent bce0984 commit a75bbac

File tree

2 files changed

+6
-32
lines changed

2 files changed

+6
-32
lines changed

.github/workflows/ci-docker-hotrod.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,6 @@ permissions:
1818
jobs:
1919
hotrod:
2020
runs-on: ubuntu-latest
21-
strategy:
22-
fail-fast: false
23-
matrix:
24-
jaeger-version: [v1, v2]
25-
2621
steps:
2722
- uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
2823
with:
@@ -58,7 +53,7 @@ jobs:
5853
esac
5954
6055
- name: Build, test, and publish hotrod image
61-
run: bash scripts/build-hotrod-image.sh ${{ env.BUILD_FLAGS }} -v ${{ matrix.jaeger-version }}
56+
run: bash scripts/build-hotrod-image.sh ${{ env.BUILD_FLAGS }}
6257
env:
6358
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
6459
QUAY_TOKEN: ${{ secrets.QUAY_TOKEN }}

scripts/build-hotrod-image.sh

Lines changed: 5 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -6,24 +6,21 @@
66
set -euf -o pipefail
77

88
print_help() {
9-
echo "Usage: $0 [-h] [-l] [-o] [-p platforms] [-v jaeger_version]"
9+
echo "Usage: $0 [-h] [-l] [-o] [-p platforms]"
1010
echo "-h: Print help"
1111
echo "-l: Enable local-only mode that only pushes images to local registry"
1212
echo "-o: overwrite image in the target remote repository even if the semver tag already exists"
1313
echo "-p: Comma-separated list of platforms to build for (default: all supported)"
14-
echo "-v: Jaeger version to use for hotrod image (v1 or v2, default: v1)"
1514
exit 1
1615
}
1716

1817
docker_compose_file="./examples/hotrod/docker-compose.yml"
1918
platforms="$(make echo-linux-platforms)"
2019
current_platform="$(go env GOOS)/$(go env GOARCH)"
21-
jaeger_version="v1"
22-
binary="all-in-one"
2320
FLAGS=()
2421
success="false"
2522

26-
while getopts "hlop:v:" opt; do
23+
while getopts "hlop:" opt; do
2724
case "${opt}" in
2825
l)
2926
# in the local-only mode the images will only be pushed to local registry
@@ -35,30 +32,12 @@ while getopts "hlop:v:" opt; do
3532
p)
3633
platforms=${OPTARG}
3734
;;
38-
v)
39-
jaeger_version=${OPTARG}
40-
;;
4135
*)
4236
print_help
4337
;;
4438
esac
4539
done
4640

47-
case "$jaeger_version" in
48-
v1)
49-
docker_compose_file="./examples/hotrod/docker-compose.yml"
50-
binary="all-in-one"
51-
;;
52-
v2)
53-
docker_compose_file="./examples/hotrod/docker-compose-v2.yml"
54-
binary="jaeger"
55-
;;
56-
*)
57-
echo "Invalid Jaeger version provided: $jaeger_version"
58-
print_help
59-
;;
60-
esac
61-
6241
set -x
6342

6443
dump_logs() {
@@ -94,9 +73,9 @@ done
9473
# so we do not pass flags like -b and -t.
9574
bash scripts/build-upload-a-docker-image.sh -l -c example-hotrod -d examples/hotrod -p "${current_platform}"
9675

97-
# Build all-in-one (for v1) or jaeger (for v2) image locally (-l) for integration test
98-
make build-${binary}
99-
bash scripts/build-upload-a-docker-image.sh -l -b -c "${binary}" -d cmd/"${binary}" -p "${current_platform}" -t release
76+
# Build all-in-one image locally (-l) for integration test
77+
make build-all-in-one
78+
bash scripts/build-upload-a-docker-image.sh -l -b -c all-in-one -d cmd/all-in-one -p "${current_platform}" -t release
10079

10180
echo '::group:: docker compose'
10281
JAEGER_VERSION=$GITHUB_SHA REGISTRY="localhost:5000/" docker compose -f "$docker_compose_file" up -d

0 commit comments

Comments
 (0)