Skip to content

Commit abc2d1f

Browse files
Merge 8cd317b into 54d3846
2 parents 54d3846 + 8cd317b commit abc2d1f

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

ydb/core/persqueue/pqtablet/pq_impl.cpp

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3509,11 +3509,6 @@ bool TPersQueue::CanProcessWriteTxs() const
35093509
return !WriteTxs.empty();
35103510
}
35113511

3512-
bool TPersQueue::CanProcessDeleteTxs() const
3513-
{
3514-
return !DeleteTxs.empty();
3515-
}
3516-
35173512
bool TPersQueue::CanProcessTxWrites() const
35183513
{
35193514
return !NewSupportivePartitions.empty();
@@ -3551,7 +3546,6 @@ void TPersQueue::BeginWriteTxs(const TActorContext& ctx)
35513546
bool canProcess =
35523547
CanProcessProposeTransactionQueue() ||
35533548
CanProcessWriteTxs() ||
3554-
CanProcessDeleteTxs() ||
35553549
CanProcessTxWrites() ||
35563550
TxWritesChanged
35573551
;
@@ -3562,9 +3556,8 @@ void TPersQueue::BeginWriteTxs(const TActorContext& ctx)
35623556
auto request = MakeHolder<TEvKeyValue::TEvRequest>();
35633557
request->Record.SetCookie(WRITE_TX_COOKIE);
35643558

3565-
ProcessProposeTransactionQueue(ctx);
3559+
ProcessProposeTransactionQueue(ctx, request->Record);
35663560
ProcessWriteTxs(ctx, request->Record);
3567-
ProcessDeleteTxs(ctx, request->Record);
35683561
AddCmdWriteTabletTxInfo(request->Record);
35693562

35703563
WriteTxsInProgress = true;
@@ -3620,10 +3613,15 @@ void TPersQueue::TryWriteTxs(const TActorContext& ctx)
36203613
}
36213614
}
36223615

3623-
void TPersQueue::ProcessProposeTransactionQueue(const TActorContext& ctx)
3616+
void TPersQueue::ProcessProposeTransactionQueue(const TActorContext& ctx,
3617+
NKikimrClient::TKeyValueRequest& request)
36243618
{
36253619
PQ_ENSURE(!WriteTxsInProgress);
36263620

3621+
if (CanProcessProposeTransactionQueue()) {
3622+
ProcessDeleteTxs(ctx, request);
3623+
}
3624+
36273625
while (CanProcessProposeTransactionQueue()) {
36283626
const auto front = std::move(EvProposeTransactionQueue.front());
36293627
EvProposeTransactionQueue.pop_front();

ydb/core/persqueue/pqtablet/pq_impl.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,8 @@ class TPersQueue : public NKeyValue::TKeyValueFlat {
354354
const TActorContext& ctx);
355355
void TryWriteTxs(const TActorContext& ctx);
356356

357-
void ProcessProposeTransactionQueue(const TActorContext& ctx);
357+
void ProcessProposeTransactionQueue(const TActorContext& ctx,
358+
NKikimrClient::TKeyValueRequest& request);
358359
void ProcessPlanStep(const TActorId& sender, std::unique_ptr<TEvTxProcessing::TEvPlanStep>&& ev,
359360
const TActorContext& ctx);
360361
void ProcessWriteTxs(const TActorContext& ctx,
@@ -503,7 +504,6 @@ class TPersQueue : public NKeyValue::TKeyValueFlat {
503504

504505
bool CanProcessProposeTransactionQueue() const;
505506
bool CanProcessWriteTxs() const;
506-
bool CanProcessDeleteTxs() const;
507507
bool CanProcessTxWrites() const;
508508

509509
ui64 GetGeneration();

0 commit comments

Comments
 (0)