feat(Preview): add preview for topics #2292
Conversation
|
@artemmufazalov @astandrik design review passed. |
| export function PreviewContainer(props: PreviewContainerProps) { | ||
| const {type} = props; | ||
| const isTable = isTableType(type); | ||
| const isTopic = type === EPathType.EPathTypePersQueueGroup; |
There was a problem hiding this comment.
Please, rebase you PR and check whether it works for topics inside CDC. If it doesn't work, create an issue and disable preview for them
There was a problem hiding this comment.
I mean EPathSubType.EPathSubTypeStreamImpl, I restored them here: #2281
Raubzeug
force-pushed
the
topic-preview
branch
2 times, most recently
from
98e2a1b to
285f8db
Compare
| @@ -71,7 +74,7 @@ export const getSchemaControls = | |||
| column_table: openPreview, | |||
|
|
|||
| index_table: undefined, | |||
| topic: undefined, | |||
| topic: isTopicPreviewAvailable && !meta?.subType ? openPreview : undefined, | |||
There was a problem hiding this comment.
You should also turn off preview in preview table component. Currently there are not preview button for topic, but if I open preview and then try to navigate from table to cdc impl topic, I will receive an error
|
@artemmufazalov fixed, stand redeployed |
| if (isTopic && isTopicPreviewAvailable) { | ||
|
|
||
| // preview is not available for topics inside CDC (has subtype) | ||
| if (isTopic && !subType && isTopicPreviewAvailable) { |
There was a problem hiding this comment.
You turned off preview for every topic.
Every element has subtype, in most cases it is EPathSubTypeEmpty, so you should check EPathSubTypeStreamImpl explicitly
Closes #1943
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔺
Current: 83.58 MB | Main: 83.57 MB
Diff: +0.02 MB (0.02%)
ℹ️ CI Information