[receiver/datadog] Bump Semantic Conventions

This addresses part of the concerns raised in open-telemetry#36924. Up until now,
datadogreceiver used v1.16 of the semantic conventions, leading to mismatches
in field names.

Author: xiu

receiver/datadogreceiver/internal/translator/series_test.go

@@ -14,6 +14,7 @@ import (
 	"github.com/stretchr/testify/require"
 	"go.opentelemetry.io/collector/component"
 	"go.opentelemetry.io/collector/pdata/pmetric"
+	semconv "go.opentelemetry.io/collector/semconv/v1.27.0"
 )
 
 func strPtr(s string) *string       { return &s }
@@ -400,13 +401,13 @@ func TestTranslateSeriesV2(t *testing.T) {
 				requireMetricAndDataPointCounts(t, result, 1, 0)
 
 				require.Equal(t, 1, result.ResourceMetrics().Len())
-				v, exists := result.ResourceMetrics().At(0).Resource().Attributes().Get("host.name")
+				v, exists := result.ResourceMetrics().At(0).Resource().Attributes().Get(semconv.AttributeHostName)
 				require.True(t, exists)
 				require.Equal(t, "Host1", v.AsString())
-				v, exists = result.ResourceMetrics().At(0).Resource().Attributes().Get("deployment.environment")
+				v, exists = result.ResourceMetrics().At(0).Resource().Attributes().Get(semconv.AttributeDeploymentEnvironmentName)
 				require.True(t, exists)
 				require.Equal(t, "tag1", v.AsString())
-				v, exists = result.ResourceMetrics().At(0).Resource().Attributes().Get("service.version")
+				v, exists = result.ResourceMetrics().At(0).Resource().Attributes().Get(semconv.AttributeServiceVersion)
 				require.True(t, exists)
 				require.Equal(t, "tag2", v.AsString())
 

receiver/datadogreceiver/internal/translator/tags.go

@@ -8,22 +8,22 @@ import (
 	"sync"
 
 	"go.opentelemetry.io/collector/pdata/pcommon"
-	semconv "go.opentelemetry.io/collector/semconv/v1.16.0"
+	semconv "go.opentelemetry.io/collector/semconv/v1.27.0"
 )
 
 // See:
 // https://docs.datadoghq.com/opentelemetry/schema_semantics/semantic_mapping/
 // https://github.com/DataDog/opentelemetry-mapping-go/blob/main/pkg/otlp/attributes/attributes.go
 var datadogKnownResourceAttributes = map[string]string{
-	"env":     semconv.AttributeDeploymentEnvironment,
+	"env":     semconv.AttributeDeploymentEnvironmentName,
 	"service": semconv.AttributeServiceName,
 	"version": semconv.AttributeServiceVersion,
 
 	// Container-related attributes
 	"container_id":   semconv.AttributeContainerID,
 	"container_name": semconv.AttributeContainerName,
 	"image_name":     semconv.AttributeContainerImageName,
-	"image_tag":      semconv.AttributeContainerImageTag,
+	"image_tag":      semconv.AttributeContainerImageTags,
 	"runtime":        semconv.AttributeContainerRuntime,
 
 	// Cloud-related attributes
@@ -136,8 +136,12 @@ func tagsToAttributes(tags []string, host string, stringPool *StringPool) attrib
 	for _, tag := range tags {
 		key, val = translateDatadogTagToKeyValuePair(tag)
 		if attr, ok := datadogKnownResourceAttributes[key]; ok {
-			val = stringPool.Intern(val) // No need to intern the key if we already have it
-			attrs.resource.PutStr(attr, val)
+			val = stringPool.Intern(val)                     // No need to intern the key if we already have it
+			if attr == semconv.AttributeContainerImageTags { // type: string[]
+				attrs.resource.PutEmptySlice(attr).AppendEmpty().SetStr(val)
+			} else {
+				attrs.resource.PutStr(attr, val)
+			}
 		} else {
 			key = stringPool.Intern(translateDatadogKeyToOTel(key))
 			val = stringPool.Intern(val)

receiver/datadogreceiver/internal/translator/tags_test.go

@@ -8,6 +8,7 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"go.opentelemetry.io/collector/pdata/pcommon"
+	semconv "go.opentelemetry.io/collector/semconv/v1.27.0"
 )
 
 func TestGetMetricAttributes(t *testing.T) {
@@ -32,7 +33,7 @@ func TestGetMetricAttributes(t *testing.T) {
 			tags: []string{},
 			host: "host",
 			expectedResourceAttrs: newMapFromKV(t, map[string]any{
-				"host.name": "host",
+				semconv.AttributeHostName: "host",
 			}),
 			expectedScopeAttrs: pcommon.NewMap(),
 			expectedDpAttrs:    pcommon.NewMap(),
@@ -42,10 +43,10 @@ func TestGetMetricAttributes(t *testing.T) {
 			tags: []string{"env:prod", "service:my-service", "version:1.0"},
 			host: "host",
 			expectedResourceAttrs: newMapFromKV(t, map[string]any{
-				"host.name":              "host",
-				"deployment.environment": "prod",
-				"service.name":           "my-service",
-				"service.version":        "1.0",
+				semconv.AttributeHostName:                  "host",
+				semconv.AttributeDeploymentEnvironmentName: "prod",
+				semconv.AttributeServiceName:               "my-service",
+				semconv.AttributeServiceVersion:            "1.0",
 			}),
 			expectedScopeAttrs: pcommon.NewMap(),
 			expectedDpAttrs:    pcommon.NewMap(),
@@ -55,8 +56,8 @@ func TestGetMetricAttributes(t *testing.T) {
 			tags: []string{"env:prod", "foo"},
 			host: "host",
 			expectedResourceAttrs: newMapFromKV(t, map[string]any{
-				"host.name":              "host",
-				"deployment.environment": "prod",
+				semconv.AttributeHostName:                  "host",
+				semconv.AttributeDeploymentEnvironmentName: "prod",
 			}),
 			expectedScopeAttrs: pcommon.NewMap(),
 			expectedDpAttrs: newMapFromKV(t, map[string]any{
@@ -148,3 +149,15 @@ func TestTranslateDataDogKeyToOtel(t *testing.T) {
 		})
 	}
 }
+
+func TestImageTags(t *testing.T) {
+	// make sure container.image.tags is a string[]
+	expected := "[\"tag1\"]"
+	tags := []string{"env:prod", "foo", "image_tag:tag1"}
+	host := "host"
+	pool := newStringPool()
+
+	attrs := tagsToAttributes(tags, host, pool)
+	imageTags, _ := attrs.resource.Get(semconv.AttributeContainerImageTags)
+	assert.Equal(t, expected, imageTags.AsString())
+}

receiver/datadogreceiver/internal/translator/traces_translator.go

@@ -19,7 +19,7 @@ import (
 	pb "github.com/DataDog/datadog-agent/pkg/proto/pbgo/trace"
 	"go.opentelemetry.io/collector/pdata/pcommon"
 	"go.opentelemetry.io/collector/pdata/ptrace"
-	semconv "go.opentelemetry.io/collector/semconv/v1.16.0"
+	semconv "go.opentelemetry.io/collector/semconv/v1.27.0"
 	"go.opentelemetry.io/otel/trace"
 	"google.golang.org/protobuf/proto"
 
@@ -62,14 +62,14 @@ func ToTraces(payload *pb.TracerPayload, req *http.Request) ptrace.Traces {
 	}
 	sharedAttributes := pcommon.NewMap()
 	for k, v := range map[string]string{
-		semconv.AttributeContainerID:           payload.ContainerID,
-		semconv.AttributeTelemetrySDKLanguage:  payload.LanguageName,
-		semconv.AttributeProcessRuntimeVersion: payload.LanguageVersion,
-		semconv.AttributeDeploymentEnvironment: payload.Env,
-		semconv.AttributeHostName:              payload.Hostname,
-		semconv.AttributeServiceVersion:        payload.AppVersion,
-		semconv.AttributeTelemetrySDKName:      "Datadog",
-		semconv.AttributeTelemetrySDKVersion:   payload.TracerVersion,
+		semconv.AttributeContainerID:               payload.ContainerID,
+		semconv.AttributeTelemetrySDKLanguage:      payload.LanguageName,
+		semconv.AttributeProcessRuntimeVersion:     payload.LanguageVersion,
+		semconv.AttributeDeploymentEnvironmentName: payload.Env,
+		semconv.AttributeHostName:                  payload.Hostname,
+		semconv.AttributeServiceVersion:            payload.AppVersion,
+		semconv.AttributeTelemetrySDKName:          "Datadog",
+		semconv.AttributeTelemetrySDKVersion:       payload.TracerVersion,
 	} {
 		if v != "" {
 			sharedAttributes.PutStr(k, v)

receiver/datadogreceiver/internal/translator/traces_translator_test.go

@@ -16,7 +16,7 @@ import (
 	"github.com/stretchr/testify/require"
 	vmsgp "github.com/vmihailenco/msgpack/v5"
 	"go.opentelemetry.io/collector/pdata/pcommon"
-	semconv "go.opentelemetry.io/collector/semconv/v1.16.0"
+	semconv "go.opentelemetry.io/collector/semconv/v1.27.0"
 	"google.golang.org/protobuf/proto"
 
 	"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/datadogreceiver/internal/translator/header"