Skip to content

Commit 83466aa

Browse files
xerialclaude
andauthored
Suppress AccessController deprecation warning for Java 17+ (#682)
* Suppress AccessController deprecation warning AccessController has been deprecated for removal since Java 17 as part of JEP 411. Since snappy-java needs to maintain compatibility with Java 8+, we cannot remove the AccessController.doPrivileged calls. This commit adds @SuppressWarnings("removal") to suppress the deprecation warning while maintaining backward compatibility. The AccessController calls are used to bypass SecurityManager restrictions when cleaning DirectByteBuffers. In Java 17+, these calls effectively just run the action directly since SecurityManager is being phased out. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Apply @SuppressWarnings to specific methods instead of class level Based on review feedback, narrowed the scope of @SuppressWarnings("removal") annotations to only the specific methods and code blocks that use AccessController, rather than applying it at the class level. This approach: - Reduces the scope of the suppression - Avoids hiding other potential deprecation warnings - Follows best practices for targeted warning suppression 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
1 parent b445794 commit 83466aa

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/main/java/org/xerial/snappy/pool/DirectByteBuffers.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ final class DirectByteBuffers {
3535
// and https://github.com/apache/lucene-solr/blob/7e03427fa14a024ce257babcb8362d2451941e21/lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java
3636
MethodHandle cleanHandle = null;
3737
try {
38+
@SuppressWarnings("removal") // AccessController is deprecated for removal in Java 17+
3839
final PrivilegedExceptionAction<MethodHandle> action = new PrivilegedExceptionAction<MethodHandle>() {
3940

4041
@Override
@@ -90,7 +91,9 @@ public MethodHandle run() throws Exception {
9091
}
9192
};
9293

93-
cleanHandle = AccessController.doPrivileged(action);
94+
@SuppressWarnings("removal") // AccessController is deprecated for removal in Java 17+
95+
MethodHandle temp = AccessController.doPrivileged(action);
96+
cleanHandle = temp;
9497

9598
} catch (Throwable t) {
9699
Logger.getLogger(DirectByteBuffers.class.getName()).log(Level.FINE, "Exception occurred attempting to lookup Sun specific DirectByteBuffer cleaner classes.", t);
@@ -121,6 +124,7 @@ static boolean nonNull(Object o) {
121124
*
122125
* @param buffer The {@code ByteBuffer} to release. Must not be {@code null}. Must be {@link ByteBuffer#isDirect() direct}.
123126
*/
127+
@SuppressWarnings("removal") // AccessController is deprecated for removal in Java 17+
124128
public static void releaseDirectByteBuffer(final ByteBuffer buffer)
125129
{
126130
assert buffer != null && buffer.isDirect();

0 commit comments

Comments
 (0)