Skip to content

Commit fcf713e

Browse files
authored
Fix formatting of log message args in verbose mode (#817)
This PR fixes the format of log message arguments. Previously, the arguments did not show up as key values pairs, but as a single list of args with an error message: ``` 2025-05-07 14:20:41 INFO starting operation └ ERROR: key_without_value: [operation create_table name customers columns [id name credit_card] comment <nil> constraints []] 2025-05-07 14:20:41 INFO starting operation └ ERROR: key_without_value: [operation create_table name bills columns [id date quantity] comment <nil> constraints []] 2025-05-07 14:20:41 INFO starting operation └ ERROR: key_without_value: [operation create_table name sellers columns [name zip description] comment <nil> constraints []] ```
1 parent 542db44 commit fcf713e

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

pkg/migrations/logger.go

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -38,31 +38,31 @@ func NewNoopLogger() Logger {
3838
}
3939

4040
func (l *migrationLogger) LogMigrationStart(m *Migration) {
41-
l.logger.Info("starting migration", l.logger.Args([]any{
41+
l.logger.Info("starting migration", l.logger.Args(
4242
"name", m.Name,
4343
"operation_count", len(m.Operations),
44-
}))
44+
))
4545
}
4646

4747
func (l *migrationLogger) LogMigrationComplete(m *Migration) {
48-
l.logger.Info("completing migration", l.logger.Args([]any{
48+
l.logger.Info("completing migration", l.logger.Args(
4949
"name", m.Name,
5050
"operation_count", len(m.Operations),
51-
}))
51+
))
5252
}
5353

5454
func (l *migrationLogger) LogMigrationRollback(m *Migration) {
55-
l.logger.Info("rolling back migration", l.logger.Args([]any{
55+
l.logger.Info("rolling back migration", l.logger.Args(
5656
"name", m.Name,
5757
"operation_count", len(m.Operations),
58-
}))
58+
))
5959
}
6060

6161
func (l *migrationLogger) LogMigrationRollbackComplete(m *Migration) {
62-
l.logger.Info("rolled back migration", l.logger.Args([]any{
62+
l.logger.Info("rolled back migration", l.logger.Args(
6363
"name", m.Name,
6464
"operation_count", len(m.Operations),
65-
}))
65+
))
6666
}
6767

6868
func (l *migrationLogger) LogBackfillStart(table string) {
@@ -82,15 +82,15 @@ func (l *migrationLogger) LogSchemaDeletion(migration, schema string) {
8282
}
8383

8484
func (l migrationLogger) LogOperationStart(op Operation) {
85-
l.logger.Info("starting operation", l.logger.Args(l.extractOpArgs(op)))
85+
l.logger.Info("starting operation", l.logger.Args(l.extractOpArgs(op)...))
8686
}
8787

8888
func (l migrationLogger) LogOperationComplete(op Operation) {
89-
l.logger.Info("completing operation", l.logger.Args(l.extractOpArgs(op)))
89+
l.logger.Info("completing operation", l.logger.Args(l.extractOpArgs(op)...))
9090
}
9191

9292
func (l migrationLogger) LogOperationRollback(op Operation) {
93-
l.logger.Info("rolling back operation", l.logger.Args(l.extractOpArgs(op)))
93+
l.logger.Info("rolling back operation", l.logger.Args(l.extractOpArgs(op)...))
9494
}
9595

9696
func (l migrationLogger) Info(msg string, args ...any) {

0 commit comments

Comments
 (0)