Add new DBAction to rename tables (#893)

Related to #742

Author: kvch

pkg/migrations/dbactions.go

@@ -49,6 +49,29 @@ func (a *dropColumnAction) dropMultipleColumns() string {
 	return strings.Join(cols, ", ")
 }
 
+// renameTableAction is a DBAction that renames a table.
+type renameTableAction struct {
+	conn db.DB
+
+	from string
+	to   string
+}
+
+func NewRenameTableAction(conn db.DB, from, to string) *renameTableAction {
+	return &renameTableAction{
+		conn: conn,
+		from: from,
+		to:   to,
+	}
+}
+
+func (a *renameTableAction) Execute(ctx context.Context) error {
+	_, err := a.conn.ExecContext(ctx, fmt.Sprintf("ALTER TABLE IF EXISTS %s RENAME TO %s",
+		pq.QuoteIdentifier(a.from),
+		pq.QuoteIdentifier(a.to)))
+	return err
+}
+
 // renameColumnAction is a DBAction that renames a column in a table.
 type renameColumnAction struct {
 	conn db.DB

pkg/migrations/op_drop_table.go

@@ -25,9 +25,7 @@ func (o *OpDropTable) Start(ctx context.Context, l Logger, conn db.DB, latestSch
 
 	// Soft-delete the table in order that a create table operation in the same
 	// migration can create a table with the same name
-	_, err := conn.ExecContext(ctx, fmt.Sprintf("ALTER TABLE IF EXISTS %s RENAME TO %s",
-		table.Name,
-		DeletionName(table.Name)))
+	err := NewRenameTableAction(conn, table.Name, DeletionName(table.Name)).Execute(ctx)
 	if err != nil {
 		return nil, fmt.Errorf("failed to rename table %s: %w", o.Name, err)
 	}
@@ -54,9 +52,7 @@ func (o *OpDropTable) Rollback(ctx context.Context, l Logger, conn db.DB, s *sch
 
 	// Rename the table back to its original name from its soft-deleted name
 	table := s.GetTable(o.Name)
-	_, err := conn.ExecContext(ctx, fmt.Sprintf("ALTER TABLE IF EXISTS %s RENAME TO %s",
-		DeletionName(table.Name),
-		table.Name))
+	err := NewRenameTableAction(conn, DeletionName(table.Name), table.Name).Execute(ctx)
 	if err != nil {
 		return fmt.Errorf("failed to rename table %s: %w", o.Name, err)
 	}

pkg/migrations/op_rename_table.go

@@ -4,9 +4,6 @@ package migrations
 
 import (
 	"context"
-	"fmt"
-
-	"github.com/lib/pq"
 
 	"github.com/xataio/pgroll/pkg/db"
 	"github.com/xataio/pgroll/pkg/schema"
@@ -23,11 +20,7 @@ func (o *OpRenameTable) Start(ctx context.Context, l Logger, conn db.DB, latestS
 func (o *OpRenameTable) Complete(ctx context.Context, l Logger, conn db.DB, s *schema.Schema) error {
 	l.LogOperationComplete(o)
 
-	_, err := conn.ExecContext(ctx, fmt.Sprintf("ALTER TABLE IF EXISTS %s RENAME TO %s",
-		pq.QuoteIdentifier(o.From),
-		pq.QuoteIdentifier(o.To)))
-
-	return err
+	return NewRenameTableAction(conn, o.From, o.To).Execute(ctx)
 }
 
 func (o *OpRenameTable) Rollback(ctx context.Context, l Logger, conn db.DB, s *schema.Schema) error {