New DBAction: AlterSequenceOwnerAction (#848)

Relates to #742

Author: kvch

pkg/migrations/dbactions.go

@@ -487,3 +487,51 @@ func (a *createFKConstraintAction) Execute(ctx context.Context) error {
 	_, err := a.conn.ExecContext(ctx, sql)
 	return err
 }
+
+type alterSequenceOwnerAction struct {
+	conn  db.DB
+	table string
+	from  string
+	to    string
+}
+
+func NewAlterSequenceOwnerAction(conn db.DB, table, from, to string) *alterSequenceOwnerAction {
+	return &alterSequenceOwnerAction{
+		conn:  conn,
+		table: table,
+		from:  from,
+		to:    to,
+	}
+}
+
+func (a *alterSequenceOwnerAction) Execute(ctx context.Context) error {
+	sequence := getSequenceNameForColumn(ctx, a.conn, a.table, a.from)
+	if sequence == "" {
+		return nil
+	}
+	_, err := a.conn.ExecContext(ctx, fmt.Sprintf("ALTER SEQUENCE IF EXISTS %s OWNED BY %s.%s",
+		sequence,
+		pq.QuoteIdentifier(a.table),
+		pq.QuoteIdentifier(a.to),
+	))
+
+	return err
+}
+
+func getSequenceNameForColumn(ctx context.Context, conn db.DB, tableName, columnName string) string {
+	var sequenceName string
+	query := fmt.Sprintf(`
+		SELECT pg_get_serial_sequence('%s', '%s')
+	`, pq.QuoteIdentifier(tableName), columnName)
+	rows, err := conn.QueryContext(ctx, query)
+	if err != nil {
+		return ""
+	}
+	defer rows.Close()
+
+	if err := db.ScanFirstValue(rows, &sequenceName); err != nil {
+		return ""
+	}
+
+	return sequenceName
+}

pkg/migrations/duplicate.go

@@ -355,36 +355,3 @@ func errorIgnoringErrorCode(err error, code pq.ErrorCode) error {
 
 	return err
 }
-
-func alterSequenceOwnerToDuplicatedColumn(ctx context.Context, conn db.DB, tableName, columnName string) error {
-	sequenceName := getSequenceNameForColumn(ctx, conn, tableName, columnName)
-	if sequenceName == "" {
-		// No sequence for the column
-		return nil
-	}
-	_, err := conn.ExecContext(ctx, fmt.Sprintf("ALTER SEQUENCE IF EXISTS %s OWNED BY %s.%s",
-		sequenceName,
-		pq.QuoteIdentifier(tableName),
-		pq.QuoteIdentifier(TemporaryName(columnName)),
-	))
-
-	return err
-}
-
-func getSequenceNameForColumn(ctx context.Context, conn db.DB, tableName, columnName string) string {
-	var sequenceName string
-	query := fmt.Sprintf(`
-		SELECT pg_get_serial_sequence('%s', '%s')
-	`, pq.QuoteIdentifier(tableName), columnName)
-	rows, err := conn.QueryContext(ctx, query)
-	if err != nil {
-		return ""
-	}
-	defer rows.Close()
-
-	if err := db.ScanFirstValue(rows, &sequenceName); err != nil {
-		return ""
-	}
-
-	return sequenceName
-}

pkg/migrations/op_alter_column.go

@@ -103,7 +103,7 @@ func (o *OpAlterColumn) Complete(ctx context.Context, l Logger, conn db.DB, s *s
 		}
 	}
 
-	if err := alterSequenceOwnerToDuplicatedColumn(ctx, conn, o.Table, o.Column); err != nil {
+	if err := NewAlterSequenceOwnerAction(conn, o.Table, o.Column, TemporaryName(o.Column)).Execute(ctx); err != nil {
 		return err
 	}
 

pkg/migrations/op_create_constraint.go

@@ -147,7 +147,7 @@ func (o *OpCreateConstraint) Complete(ctx context.Context, l Logger, conn db.DB,
 	}
 
 	for _, col := range o.Columns {
-		if err := alterSequenceOwnerToDuplicatedColumn(ctx, conn, o.Table, col); err != nil {
+		if err := NewAlterSequenceOwnerAction(conn, o.Table, col, TemporaryName(col)).Execute(ctx); err != nil {
 			return err
 		}
 	}

pkg/migrations/op_drop_constraint.go

@@ -92,7 +92,7 @@ func (o *OpDropConstraint) Complete(ctx context.Context, l Logger, conn db.DB, s
 		return err
 	}
 
-	if err := alterSequenceOwnerToDuplicatedColumn(ctx, conn, o.Table, column.Name); err != nil {
+	if err := NewAlterSequenceOwnerAction(conn, o.Table, column.Name, TemporaryName(column.Name)).Execute(ctx); err != nil {
 		return err
 	}
 

pkg/migrations/op_drop_multicolumn_constraint.go

@@ -109,7 +109,7 @@ func (o *OpDropMultiColumnConstraint) Complete(ctx context.Context, l Logger, co
 			return err
 		}
 
-		if err := alterSequenceOwnerToDuplicatedColumn(ctx, conn, o.Table, columnName); err != nil {
+		if err := NewAlterSequenceOwnerAction(conn, o.Table, columnName, TemporaryName(columnName)).Execute(ctx); err != nil {
 			return err
 		}