Skip to content

Commit e5e81e8

Browse files
authored
Merge pull request rust-lang#114 from knownasilya/template-lint
Add ember-cli-template-lint to default app & addon blueprints
2 parents 6291d54 + dbaf6bb commit e5e81e8

File tree

1 file changed

+34
-0
lines changed

1 file changed

+34
-0
lines changed

text/0000-add-template-lint-addon.md

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
- Start Date: 2018-01-04
2+
- RFC PR: (leave this empty)
3+
4+
# Summary
5+
6+
Add https://github.com/rwjblue/ember-cli-template-lint as a default addon for the app and addon blueprints using the recommended rules.
7+
8+
# Motivation
9+
10+
Linting and security in templates would help not only individual developers write better apps with better accessibility and security, but would also help teams to be on the same page and stick to a handful of standards.
11+
12+
# Detailed design
13+
14+
1. Move ember-cli-template-lint to the ember-cli org (better for contributing and getting work off one person, @rwjblue)
15+
2. Add the dependency to the app blueprint here: https://github.com/ember-cli/ember-cli/blob/master/blueprints/app/files/package.json#L19
16+
3. Also add it to the addon blueprint, like the eslint addon here: https://github.com/ember-cli/ember-cli/blob/master/blueprints/addon/index.js#L66
17+
18+
# How We Teach This
19+
20+
The same way that we teach ESLint being on by default.
21+
22+
# Drawbacks
23+
24+
- More chatter in the terminal.
25+
- An additional dependency.
26+
- Recommended rules might not be good for everyone.. but that same issue probably exists with ESLint.
27+
28+
# Alternatives
29+
30+
Do nothing and have people write sub par template code.
31+
32+
# Unresolved questions
33+
34+
None

0 commit comments

Comments
 (0)