Skip to content

Commit d771566

Browse files
KaptenJanssonKaptenJansson
committed
Add adapter artifacts
1 parent 938f231 commit d771566

File tree

4 files changed

+36
-12
lines changed

4 files changed

+36
-12
lines changed

‎release/adapter.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1120,6 +1120,12 @@ var chromeShim = {
11201120
'The RTCPeerConnection\'s signalingState is \'closed\'.',
11211121
'InvalidStateError');
11221122
}
1123+
// We can not yet check for sender instanceof RTCRtpSender
1124+
// since we shim RTPSender. So we check if sender._pc is set.
1125+
if (!sender._pc) {
1126+
throw new DOMException('Argument 1 of RTCPeerConnection.removeTrack ' +
1127+
'does not implement interface RTCRtpSender.', 'TypeError');
1128+
}
11231129
var isLocal = sender._pc === pc;
11241130
if (!isLocal) {
11251131
throw new DOMException('Sender was not created by this connection.',
@@ -1188,7 +1194,7 @@ var chromeShim = {
11881194
var server = pcConfig.iceServers[i];
11891195
if (!server.hasOwnProperty('urls') &&
11901196
server.hasOwnProperty('url')) {
1191-
console.warn('RTCIceServer.url is deprecated! Use urls instead.');
1197+
utils.deprecated('RTCIceServer.url', 'RTCIceServer.urls');
11921198
server = JSON.parse(JSON.stringify(server));
11931199
server.urls = server.url;
11941200
newIceServers.push(server);
@@ -3509,8 +3515,8 @@ module.exports = function(window) {
35093515
return getUserMedia_(constraints, onSuccess, onError);
35103516
}
35113517
// Replace Firefox 44+'s deprecation warning with unprefixed version.
3512-
console.warn('navigator.getUserMedia has been replaced by ' +
3513-
'navigator.mediaDevices.getUserMedia');
3518+
utils.deprecated('navigator.getUserMedia',
3519+
'navigator.mediaDevices.getUserMedia');
35143520
navigator.mediaDevices.getUserMedia(constraints).then(onSuccess, onError);
35153521
};
35163522
};

‎release/adapter_no_edge.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,12 @@ var chromeShim = {
487487
'The RTCPeerConnection\'s signalingState is \'closed\'.',
488488
'InvalidStateError');
489489
}
490+
// We can not yet check for sender instanceof RTCRtpSender
491+
// since we shim RTPSender. So we check if sender._pc is set.
492+
if (!sender._pc) {
493+
throw new DOMException('Argument 1 of RTCPeerConnection.removeTrack ' +
494+
'does not implement interface RTCRtpSender.', 'TypeError');
495+
}
490496
var isLocal = sender._pc === pc;
491497
if (!isLocal) {
492498
throw new DOMException('Sender was not created by this connection.',
@@ -555,7 +561,7 @@ var chromeShim = {
555561
var server = pcConfig.iceServers[i];
556562
if (!server.hasOwnProperty('urls') &&
557563
server.hasOwnProperty('url')) {
558-
console.warn('RTCIceServer.url is deprecated! Use urls instead.');
564+
utils.deprecated('RTCIceServer.url', 'RTCIceServer.urls');
559565
server = JSON.parse(JSON.stringify(server));
560566
server.urls = server.url;
561567
newIceServers.push(server);
@@ -1367,8 +1373,8 @@ module.exports = function(window) {
13671373
return getUserMedia_(constraints, onSuccess, onError);
13681374
}
13691375
// Replace Firefox 44+'s deprecation warning with unprefixed version.
1370-
console.warn('navigator.getUserMedia has been replaced by ' +
1371-
'navigator.mediaDevices.getUserMedia');
1376+
utils.deprecated('navigator.getUserMedia',
1377+
'navigator.mediaDevices.getUserMedia');
13721378
navigator.mediaDevices.getUserMedia(constraints).then(onSuccess, onError);
13731379
};
13741380
};

‎release/adapter_no_edge_no_global.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,12 @@ var chromeShim = {
487487
'The RTCPeerConnection\'s signalingState is \'closed\'.',
488488
'InvalidStateError');
489489
}
490+
// We can not yet check for sender instanceof RTCRtpSender
491+
// since we shim RTPSender. So we check if sender._pc is set.
492+
if (!sender._pc) {
493+
throw new DOMException('Argument 1 of RTCPeerConnection.removeTrack ' +
494+
'does not implement interface RTCRtpSender.', 'TypeError');
495+
}
490496
var isLocal = sender._pc === pc;
491497
if (!isLocal) {
492498
throw new DOMException('Sender was not created by this connection.',
@@ -555,7 +561,7 @@ var chromeShim = {
555561
var server = pcConfig.iceServers[i];
556562
if (!server.hasOwnProperty('urls') &&
557563
server.hasOwnProperty('url')) {
558-
console.warn('RTCIceServer.url is deprecated! Use urls instead.');
564+
utils.deprecated('RTCIceServer.url', 'RTCIceServer.urls');
559565
server = JSON.parse(JSON.stringify(server));
560566
server.urls = server.url;
561567
newIceServers.push(server);
@@ -1367,8 +1373,8 @@ module.exports = function(window) {
13671373
return getUserMedia_(constraints, onSuccess, onError);
13681374
}
13691375
// Replace Firefox 44+'s deprecation warning with unprefixed version.
1370-
console.warn('navigator.getUserMedia has been replaced by ' +
1371-
'navigator.mediaDevices.getUserMedia');
1376+
utils.deprecated('navigator.getUserMedia',
1377+
'navigator.mediaDevices.getUserMedia');
13721378
navigator.mediaDevices.getUserMedia(constraints).then(onSuccess, onError);
13731379
};
13741380
};

‎release/adapter_no_global.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1120,6 +1120,12 @@ var chromeShim = {
11201120
'The RTCPeerConnection\'s signalingState is \'closed\'.',
11211121
'InvalidStateError');
11221122
}
1123+
// We can not yet check for sender instanceof RTCRtpSender
1124+
// since we shim RTPSender. So we check if sender._pc is set.
1125+
if (!sender._pc) {
1126+
throw new DOMException('Argument 1 of RTCPeerConnection.removeTrack ' +
1127+
'does not implement interface RTCRtpSender.', 'TypeError');
1128+
}
11231129
var isLocal = sender._pc === pc;
11241130
if (!isLocal) {
11251131
throw new DOMException('Sender was not created by this connection.',
@@ -1188,7 +1194,7 @@ var chromeShim = {
11881194
var server = pcConfig.iceServers[i];
11891195
if (!server.hasOwnProperty('urls') &&
11901196
server.hasOwnProperty('url')) {
1191-
console.warn('RTCIceServer.url is deprecated! Use urls instead.');
1197+
utils.deprecated('RTCIceServer.url', 'RTCIceServer.urls');
11921198
server = JSON.parse(JSON.stringify(server));
11931199
server.urls = server.url;
11941200
newIceServers.push(server);
@@ -3509,8 +3515,8 @@ module.exports = function(window) {
35093515
return getUserMedia_(constraints, onSuccess, onError);
35103516
}
35113517
// Replace Firefox 44+'s deprecation warning with unprefixed version.
3512-
console.warn('navigator.getUserMedia has been replaced by ' +
3513-
'navigator.mediaDevices.getUserMedia');
3518+
utils.deprecated('navigator.getUserMedia',
3519+
'navigator.mediaDevices.getUserMedia');
35143520
navigator.mediaDevices.getUserMedia(constraints).then(onSuccess, onError);
35153521
};
35163522
};

0 commit comments

Comments
 (0)