Skip to content

Commit 8d888d4

Browse files
authored
Infrastructure: Check vnu-jar warnings in addition to errors (pull #1671)
* Check for VNU warnings * Turn off all current warnings in the config * fix: remove "type" from style tags * fix: role="main" on main element * chore: Add tracking issues for validator warnings
1 parent 56cff78 commit 8d888d4

File tree

5 files changed

+12
-4
lines changed

5 files changed

+12
-4
lines changed

.vnurc

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,11 @@ Attribute “aria-posinset” not allowed on element “tr” at this point.
1212
Attribute “aria-setsize” not allowed on element “tr” at this point.
1313
# Ignoring role meter
1414
Bad value “meter” for attribute “role” on element “div”.
15+
# https://github.com/w3c/aria-practices/issues/1675
16+
The “type” attribute is unnecessary for JavaScript resources.
17+
# https://github.com/w3c/aria-practices/issues/1676
18+
The “row” role is unnecessary for element “tr”.
19+
# https://github.com/w3c/aria-practices/issues/1677
20+
Attribute “aria-activedescendant” value should either refer to a descendant element, or should be accompanied by attribute “aria-owns”.
21+
# https://github.com/w3c/aria-practices/issues/1678
22+
Section lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all sections.

examples/landmarks/form.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<link href="css/bootstrap-accessibility.css" rel="stylesheet" media="screen"/>
99
<link href="css/visua11y.css" rel="stylesheet" media="screen"/>
1010
<link href="css/common.css" rel="stylesheet" media="screen"/>
11-
<style type="text/css">
11+
<style>
1212
label,
1313
input[type=submit] {
1414
display: block;

examples/radio/radio-activedescendant.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<li><a href="../../#radiobutton">Design Pattern</a></li>
2525
</ul>
2626
</nav>
27-
<main role="main">
27+
<main>
2828
<h1>Radio Group Example Using aria-activedescendant</h1>
2929
<p>
3030
This example implements the features of the <a href="../../#radiobutton">Radio Group Design Pattern</a>

examples/radio/radio.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<li><a href="../../#radiobutton">Design Pattern</a></li>
2525
</ul>
2626
</nav>
27-
<main role="main">
27+
<main>
2828
<h1>Radio Group Example Using Roving tabindex</h1>
2929
<p>
3030
This example implements the features of the <a href="../../#radiobutton">Radio Group Design Pattern</a>

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"regression": "ava --timeout=1m",
2020
"regression-report": "node test/util/report",
2121
"test": "npm run lint && npm run regression",
22-
"vnu-jar": "java -jar node_modules/vnu-jar/build/dist/vnu.jar --errors-only --filterfile .vnurc --no-langdetect --skip-non-html aria-practices.html examples/",
22+
"vnu-jar": "java -jar node_modules/vnu-jar/build/dist/vnu.jar --filterfile .vnurc --no-langdetect --skip-non-html aria-practices.html examples/",
2323
"create-gh-project": "node ./scripts/create-gh-project.js",
2424
"postinstall": "husky install",
2525
"prepublishOnly": "pinst --disable",

0 commit comments

Comments
 (0)