fix(VList): ignore invalid itemType values

fixes #21728

Author: KaelWD

packages/vuetify/src/components/VList/VList.tsx

@@ -42,15 +42,21 @@ import type { GenericProps, SelectItemKey } from '@/util'
 
 export interface InternalListItem<T = any> extends ListItem<T> {}
 
+const itemTypes = new Set(['item', 'divider', 'subheader'])
+
 function transformItem (props: ItemProps, item: any): ListItem {
-  const type = getPropertyFromItem(item, props.itemType, 'item')
   const title = isPrimitive(item) ? item : getPropertyFromItem(item, props.itemTitle)
   const value = isPrimitive(item) ? item : getPropertyFromItem(item, props.itemValue, undefined)
   const children = getPropertyFromItem(item, props.itemChildren)
   const itemProps = props.itemProps === true
     ? omit(item, ['children'])
     : getPropertyFromItem(item, props.itemProps)
 
+  let type = getPropertyFromItem(item, props.itemType, 'item')
+  if (!itemTypes.has(type)) {
+    type = 'item'
+  }
+
   const _props = {
     title,
     value,

packages/vuetify/src/composables/list-items.ts

@@ -59,11 +59,15 @@ export const makeItemsProps = propsFactory({
   valueComparator: Function as PropType<typeof deepEqual>,
 }, 'list-items')
 
-export function transformItem (props: Omit<ItemProps, 'items'>, item: any): ListItem {
+const itemTypes = new Set(['item', 'divider', 'subheader'])
+
+export function transformItem (
+  props: Pick<ItemProps, typeof transformItem.neededProps[number]>,
+  item: any
+): ListItem {
   const title = getPropertyFromItem(item, props.itemTitle, item)
   const value = getPropertyFromItem(item, props.itemValue, title)
   const children = getPropertyFromItem(item, props.itemChildren)
-  const type = getPropertyFromItem(item, props.itemType, 'item')
   const itemProps = props.itemProps === true
     ? typeof item === 'object' && item != null && !Array.isArray(item)
       ? 'children' in item
@@ -72,6 +76,11 @@ export function transformItem (props: Omit<ItemProps, 'items'>, item: any): List
       : undefined
     : getPropertyFromItem(item, props.itemProps)
 
+  let type = getPropertyFromItem(item, props.itemType, 'item')
+  if (!itemTypes.has(type)) {
+    type = 'item'
+  }
+
   const _props = {
     title,
     value,
@@ -88,16 +97,20 @@ export function transformItem (props: Omit<ItemProps, 'items'>, item: any): List
   }
 }
 
-export function transformItems (props: Omit<ItemProps, 'items'>, items: ItemProps['items']) {
-  const _props = pick(props, [
-    'itemTitle',
-    'itemValue',
-    'itemChildren',
-    'itemProps',
-    'itemType',
-    'returnObject',
-    'valueComparator',
-  ])
+transformItem.neededProps = [
+  'itemTitle',
+  'itemValue',
+  'itemChildren',
+  'itemProps',
+  'itemType',
+] as const
+
+export function transformItems (
+  props: Pick<ItemProps, typeof transformItem.neededProps[number]>,
+  items: ItemProps['items']
+) {
+  // avoid reactive access in the loop
+  const _props = pick(props, transformItem.neededProps)
 
   const array: ListItem[] = []
   for (const item of items) {
@@ -144,15 +157,7 @@ export function useItems (props: ItemProps) {
     const _returnObject = props.returnObject
     const hasValueComparator = !!props.valueComparator
     const valueComparator = props.valueComparator || deepEqual
-    const _props = pick(props, [
-      'itemTitle',
-      'itemValue',
-      'itemChildren',
-      'itemProps',
-      'itemType',
-      'returnObject',
-      'valueComparator',
-    ])
+    const _props = pick(props, transformItem.neededProps)
 
     const returnValue: ListItem[] = []
     main: for (const v of value) {

packages/vuetify/src/util/helpers.ts

@@ -225,7 +225,7 @@ type MaybePick<
 export function pick<
   T extends object,
   U extends Extract<keyof T, string>
-> (obj: T, paths: U[]): MaybePick<T, U> {
+> (obj: T, paths: readonly U[]): MaybePick<T, U> {
   const found: any = {}
 
   for (const key of paths) {