update json tags and add tests for syncvolume api

Signed-off-by: Nikhil Barge <[email protected]>

Author: nikhilbarge

cns/client_test.go

@@ -1763,34 +1763,34 @@ func TestClient(t *testing.T) {
 	t.Logf("syncDatastore on %v with full sync successful\n", dsUrl)
 
 	// Test CnsSyncVolume API
-	/*
-		t.Logf("Calling syncVolume for volumeId: %v ...\n", volumeId)
-		var cnsSyncVolumeSpecs []cnstypes.CnsSyncVolumeSpec
-		dataStore := ds.Reference()
-		cnsSyncVolumeSpec := cnstypes.CnsSyncVolumeSpec{
-			VolumeId: cnstypes.CnsVolumeId{
-				Id: volumeId,
-			},
-			Datastore: &dataStore,
-			SyncMode:  []string{string(cnstypes.CnsSyncVolumeModeSPACE_USAGE)},
-		}
-		cnsSyncVolumeSpecs = append(cnsSyncVolumeSpecs, cnsSyncVolumeSpec)
-		syncVolumeTask, err := cnsClient.SyncVolume(ctx, cnsSyncVolumeSpecs)
-		if err != nil {
-			t.Errorf("Failed to sync volume %v. Error: %+v \n", volumeId, err)
-			t.Fatal(err)
-		}
-		syncVolumeTaskInfo, err := GetTaskInfo(ctx, syncVolumeTask)
-		if err != nil {
-			t.Errorf("Failed to get sync volume taskInfo. Error: %+v \n", err)
-			t.Fatal(err)
-		}
-		if syncVolumeTaskInfo.State != vim25types.TaskInfoStateSuccess {
-			t.Errorf("Failed to sync volume. Error: %+v \n", syncVolumeTaskInfo.Error)
-			t.Fatalf("%+v", syncVolumeTaskInfo.Error)
-		}
-		t.Logf("syncVolume for volumeId: %v successful...\n", volumeId)
-	*/
+
+	t.Logf("Calling syncVolume for volumeId: %v ...\n", volumeId)
+	var cnsSyncVolumeSpecs []cnstypes.CnsSyncVolumeSpec
+	dataStore := ds.Reference()
+	cnsSyncVolumeSpec := cnstypes.CnsSyncVolumeSpec{
+		VolumeId: cnstypes.CnsVolumeId{
+			Id: volumeId,
+		},
+		Datastore: &dataStore,
+		SyncMode:  []string{string(cnstypes.CnsSyncVolumeModeSPACE_USAGE)},
+	}
+
+	cnsSyncVolumeSpecs = append(cnsSyncVolumeSpecs, cnsSyncVolumeSpec)
+	syncVolumeTask, err := cnsClient.SyncVolume(ctx, cnsSyncVolumeSpecs)
+	if err != nil {
+		t.Errorf("Failed to sync volume %v. Error: %+v \n", volumeId, err)
+		t.Fatal(err)
+	}
+	syncVolumeTaskInfo, err := GetTaskInfo(ctx, syncVolumeTask)
+	if err != nil {
+		t.Errorf("Failed to get sync volume taskInfo. Error: %+v \n", err)
+		t.Fatal(err)
+	}
+	if syncVolumeTaskInfo.State != vim25types.TaskInfoStateSuccess {
+		t.Errorf("Failed to sync volume. Error: %+v \n", syncVolumeTaskInfo.Error)
+		t.Fatalf("%+v", syncVolumeTaskInfo.Error)
+	}
+	t.Logf("syncVolume for volumeId: %v successful...\n", volumeId)
 
 }
 

cns/types/types.go

@@ -964,24 +964,24 @@ func init() {
 }
 
 type CnsSyncVolumeRequestType struct {
-	This      types.ManagedObjectReference `xml:"_this"`
-	SyncSpecs []CnsSyncVolumeSpec          `xml:"syncSpecs,omitempty"`
+	This      types.ManagedObjectReference `xml:"_this" json:"-"`
+	SyncSpecs []CnsSyncVolumeSpec          `xml:"syncSpecs,omitempty" json:"syncSpecs,omitempty"`
 }
 
 func init() {
 	types.Add("vsan:CnsSyncVolumeRequestType", reflect.TypeOf((*CnsSyncVolumeRequestType)(nil)).Elem())
 }
 
 type CnsSyncVolumeResponse struct {
-	Returnval types.ManagedObjectReference `xml:"returnval"`
+	Returnval types.ManagedObjectReference `xml:"returnval" json:"returnval"`
 }
 
 type CnsSyncVolumeSpec struct {
 	types.DynamicData
 
-	VolumeId  CnsVolumeId                   `xml:"volumeId"`
-	Datastore *types.ManagedObjectReference `xml:"datastore,omitempty"`
-	SyncMode  []string                      `xml:"syncMode,omitempty"`
+	VolumeId  CnsVolumeId                   `xml:"volumeId" json:"volumeId"`
+	Datastore *types.ManagedObjectReference `xml:"datastore,omitempty" json:"datastore,omitempty"`
+	SyncMode  []string                      `xml:"syncMode,omitempty" json:"syncMode,omitempty"`
 }
 
 func init() {