Skip to content

Commit aa5a378

Browse files
committed
govc: Support -p and -s in with single task.set
Progress (-p) must be '100' before state (-s) can be set to 'success'. Signed-off-by: Doug MacEachern <[email protected]>
1 parent e887ea4 commit aa5a378

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

cli/task/set.go

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,8 @@ func (cmd *set) Description() string {
4343
4444
Examples:
4545
id=$(govc task.create com.vmware.govmomi.simulator.test)
46-
govc task.set $id -s error`
46+
govc task.set $id -s error
47+
govc task.set $id -p 100 -s success`
4748
}
4849

4950
func (cmd *set) Usage() string {
@@ -67,6 +68,13 @@ func (cmd *set) Run(ctx context.Context, f *flag.FlagSet) error {
6768

6869
task := object.NewTask(c, ref)
6970

71+
if cmd.progress != 0 {
72+
err := task.UpdateProgress(ctx, cmd.progress)
73+
if err != nil {
74+
return err
75+
}
76+
}
77+
7078
var fault *types.LocalizedMethodFault
7179

7280
if cmd.err != "" {
@@ -84,13 +92,6 @@ func (cmd *set) Run(ctx context.Context, f *flag.FlagSet) error {
8492
}
8593
}
8694

87-
if cmd.progress != 0 {
88-
err := task.UpdateProgress(ctx, cmd.progress)
89-
if err != nil {
90-
return err
91-
}
92-
}
93-
9495
if cmd.desc.Key != "" {
9596
err := task.SetDescription(ctx, cmd.desc)
9697
if err != nil {

0 commit comments

Comments
 (0)