vcsim: copy device list when cloning a VM

The vcsim CloneVM_Task method was sharing the config.hardware.device property
between the source and target VMs. The target VM now has a copy of the device
list so changes to it won't change the source VM's device list.

Closes #2706

Author: dougm

govc/test/vm.bats

@@ -818,6 +818,16 @@ load test_helper
   backing=$(govc device.info -json -vm "$clone" disk-* | jq .Devices[].Backing)
   assert_equal true "$(jq .EagerlyScrub <<<"$backing")"
   assert_equal false "$(jq .ThinProvisioned <<<"$backing")"
+
+  # test that each vm has a unique vmdk path
+  for item in FileName Uuid;  do
+    items=$(govc object.collect -json -type m / config.hardware.device | \
+              jq ".ChangeSet[].Val.VirtualDevice[].Backing.$item | select(. != null)")
+
+    nitems=$(wc -l <<<"$items")
+    uitems=$(sort -u <<<"$items" | wc -l)
+    assert_equal "$nitems" "$uitems"
+  done
 }
 
 @test "vm.clone change resources" {

simulator/virtual_machine.go

@@ -1769,6 +1769,15 @@ type vmFolder interface {
 	CreateVMTask(ctx *Context, c *types.CreateVM_Task) soap.HasFault
 }
 
+func (vm *VirtualMachine) cloneDevice() []types.BaseVirtualDevice {
+	src := types.ArrayOfVirtualDevice{
+		VirtualDevice: vm.Config.Hardware.Device,
+	}
+	dst := types.ArrayOfVirtualDevice{}
+	deepCopy(src, &dst)
+	return dst.VirtualDevice
+}
+
 func (vm *VirtualMachine) CloneVMTask(ctx *Context, req *types.CloneVM_Task) soap.HasFault {
 	pool := req.Spec.Location.Pool
 	if pool == nil {
@@ -1827,7 +1836,8 @@ func (vm *VirtualMachine) CloneVMTask(ctx *Context, req *types.CloneVM_Task) soa
 		config.VirtualSMCPresent = vm.Config.Hardware.VirtualSMCPresent
 
 		defaultDevices := object.VirtualDeviceList(esx.VirtualDevice)
-		devices := vm.Config.Hardware.Device
+		devices := vm.cloneDevice()
+
 		for _, device := range devices {
 			var fop types.VirtualDeviceConfigSpecFileOperation