chore: Update CI to Go 1.18

Update Go versions used (current and current-1) in various places
(workflows and Docker images). Update to current Ubuntu runner 20.04.
run go mod tidy to clean up/ correctly order Go deps.

Note: go.mod version not bumped to 1.18 to avoid issues when running
with Go 1.17.

Closes: #2785
Signed-off-by: Michael Gasch <[email protected]>

Author: Michael Gasch

.github/workflows/codeql-analysis.yml

@@ -23,7 +23,7 @@ on:
 jobs:
   analyze:
     name: Analyze
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     permissions:
       actions: read
       contents: read

.github/workflows/govmomi-build.yaml

@@ -30,7 +30,7 @@ on:
 jobs:
   artifacts:
     name: Build Snapshot Release (no upload)
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     timeout-minutes: 15
 
     steps:
@@ -40,9 +40,9 @@ jobs:
           fetch-depth: 0 # for CHANGELOG
 
       - name: Set up Go
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v3
         with:
-          go-version: 1.17
+          go-version: 1.18
 
       - name: Create CHANGELOG
         env:

.github/workflows/govmomi-check-wip.yaml

@@ -21,7 +21,7 @@ on:
 
 jobs:
   wip:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     steps:
       - name: Check WIP in PR Title
         uses: embano1/wip@v1

.github/workflows/govmomi-go-lint.yaml

@@ -25,14 +25,14 @@ jobs:
 
   lint:
     name: Lint Files
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     timeout-minutes: 10
 
     steps:
-      - name: Set up Go 1.17.x
-        uses: actions/setup-go@v2
+      - name: Set up Go
+        uses: actions/setup-go@v3
         with:
-          go-version: 1.17.x
+          go-version: 1.18
         id: go
 
       - name: Check out code

.github/workflows/govmomi-go-tests.yaml

@@ -26,15 +26,15 @@ jobs:
     name: Run Unit Tests
     strategy:
       matrix:
-        go-version: ["1.16", "1.17"]
-        platform: ["ubuntu-latest"]
+        go-version: ["1.17", "1.18"]
+        platform: ["ubuntu-20.04"]
 
     runs-on: ${{ matrix.platform }}
     timeout-minutes: 10
 
     steps:
       - name: Set up Go ${{ matrix.go-version }}
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v3
         with:
           go-version: ${{ matrix.go-version }}
         id: go

.github/workflows/govmomi-govc-tests.yaml

@@ -26,19 +26,19 @@ jobs:
     name: Run govc Tests
     strategy:
       matrix:
-        go-version: ["1.16", "1.17"]
-        platform: ["ubuntu-18.04"]
+        go-version: ["1.17", "1.18"]
+        platform: ["ubuntu-20.04"]
         cmd: ["govc-test"]
         experimental: [false]
         timeout: [10]
         include:
-          - go-version: "1.16"
-            platform: "ubuntu-18.04"
+          - go-version: "1.18"
+            platform: "ubuntu-20.04"
             cmd: "govc-test-sso"
             experimental: true
             timeout: 3
-          - go-version: "1.16"
-            platform: "ubuntu-18.04"
+          - go-version: "1.18"
+            platform: "ubuntu-20.04"
             cmd: "govc-test-sso-assert-cert"
             experimental: true
             timeout: 3
@@ -49,7 +49,7 @@ jobs:
 
     steps:
       - name: Set up Go ${{ matrix.go-version }}
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v3
         with:
           go-version: ${{ matrix.go-version }}
         id: go
@@ -58,19 +58,22 @@ jobs:
         uses: actions/checkout@v2
 
       - name: Run ${{ matrix.cmd }}
-        run: make ${{ matrix.cmd }}
+        run: |
+          # hack: https://github.com/actions/setup-go/issues/107#issuecomment-956161446
+          cp -f `which go` /usr/bin/go 
+          make ${{ matrix.cmd }}
 
   govc-docs:
     name: Verify govc docs are up2date
     strategy:
       matrix:
         go-version: ["1.17"]
-        platform: ["ubuntu-18.04"]
+        platform: ["ubuntu-20.04"]
     runs-on: ${{ matrix.platform }}
     timeout-minutes: 3
     steps:
       - name: Set up Go ${{ matrix.go-version }}
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v3
         with:
           go-version: ${{ matrix.go-version }}
         id: go

.github/workflows/govmomi-release.yaml

@@ -22,7 +22,7 @@ on:
 jobs:
   release:
     name: Create Release
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     timeout-minutes: 60
 
     steps:
@@ -35,9 +35,9 @@ jobs:
           fetch-depth: 0 # for CHANGELOG
 
       - name: Set up Go
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v3
         with:
-          go-version: 1.17
+          go-version: 1.18
 
       - name: Create RELEASE CHANGELOG
         env:
@@ -68,7 +68,7 @@ jobs:
   pull-request:
     needs: release
     name: Create CHANGELOG.md PR
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     continue-on-error: true
 
     steps:

.github/workflows/govmomi-stale.yaml

@@ -20,7 +20,7 @@ on:
 
 jobs:
   stale:
-    runs-on: "ubuntu-latest"
+    runs-on: ubuntu-20.04
 
     steps:
       - uses: "actions/stale@v3"

.github/workflows/issue-greeting.yaml

@@ -7,7 +7,7 @@ on:
 jobs:
   greeting:
     name: Send Greeting
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     # only send message to users not (yet) associated with repo
     # https://docs.github.com/en/graphql/reference/enums#commentauthorassociation
     if: github.event.issue.author_association == 'NONE'

.github/workflows/verify-docker-login.yaml

@@ -22,7 +22,7 @@ on:
 jobs:
   login:
     name: Verify Docker Login
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     timeout-minutes: 3
 
     steps: