test: add timeout to untilBrowserLog (#20905)

Author: sapphi-red

playground/hmr-ssr/__tests__/hmr-ssr.spec.ts

@@ -974,6 +974,7 @@ async function untilConsoleLog(
   expectOrder = true,
 ): Promise<string[]> {
   const { promise, resolve, reject } = promiseWithResolvers<void>()
+  let timeoutId: ReturnType<typeof setTimeout>
 
   const logsMessages = []
 
@@ -1024,12 +1025,27 @@ async function untilConsoleLog(
       }
     }
 
+    timeoutId = setTimeout(() => {
+      const nextTarget = Array.isArray(target)
+        ? expectOrder
+          ? target[0]
+          : target.join(', ')
+        : target
+      reject(
+        new Error(
+          `Timeout waiting for console logs. Waiting for: ${nextTarget}`,
+        ),
+      )
+      logsEmitter.off('log', handleMsg)
+    }, 5000)
+
     logsEmitter.on('log', handleMsg)
   } catch (err) {
     reject(err)
   }
 
   await promise
+  clearTimeout(timeoutId)
 
   return logsMessages
 }

playground/test-utils.ts

@@ -274,6 +274,7 @@ async function untilBrowserLog(
   expectOrder = true,
 ): Promise<string[]> {
   const { promise, resolve, reject } = promiseWithResolvers<void>()
+  let timeoutId: ReturnType<typeof setTimeout>
 
   const logs = []
 
@@ -322,12 +323,27 @@ async function untilBrowserLog(
       }
     }
 
+    timeoutId = setTimeout(() => {
+      const nextTarget = Array.isArray(target)
+        ? expectOrder
+          ? target[0]
+          : target.join(', ')
+        : target
+      reject(
+        new Error(
+          `Timeout waiting for browser logs. Waiting for: ${nextTarget}`,
+        ),
+      )
+      page.off('console', handleMsg)
+    }, 5000)
+
     page.on('console', handleMsg)
   } catch (err) {
     reject(err)
   }
 
   await promise
+  clearTimeout(timeoutId)
 
   return logs
 }