Skip to content

Overhaul entire hook #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jdmcd merged 3 commits into from
Oct 22, 2021
Merged

Overhaul entire hook #2

jdmcd merged 3 commits into from
Oct 22, 2021

Conversation

@gwynne
Copy link
Member

@gwynne gwynne commented Oct 22, 2021

Major points of interest:

  • Supports all currently available database drivers (SQLite, MySQL, PostgreSQL, MongoDB).
  • Basic tests.
  • Better handling of missing or out-of-order state transitions.
  • Job IDs are constrained to be unique in the database.

gwynne added 3 commits October 22, 2021 07:19
@gwynne
Package structure fixes - don't commit Package.resolved, remove old T…
72a68ef 
…ests/LinuxMain.swift
@gwynne
Retool the database hook so that all queries are valid on all databas…
fcae29d 
…es (not just SQL databases) and use queries for status transitions that yield a sensible state even if some notifications are missed or arrive out of order. Also updates documentation comments in many places and adds a migration to add a uniqueness constraint to the job ID in the database.
@gwynne
Add a basic test for the database notification hook (doesn't cover mu…
a0b926f 
…ch but does prove that it works in the simplest case).
@gwynne gwynne added bug Something isn't working enhancement New feature or request labels Oct 22, 2021
@gwynne gwynne requested a review from jdmcd October 22, 2021 12:23
@gwynne gwynne self-assigned this Oct 22, 2021
jdmcd
jdmcd approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@jdmcd jdmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdmcd jdmcd merged commit edae74c into main Oct 22, 2021
@jdmcd jdmcd deleted the overhaul-queries-and-fluent-usage branch October 22, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jdmcd jdmcd jdmcd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gwynne gwynne

Labels

bug Something isn't working enhancement New feature or request

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gwynne @jdmcd