-
Notifications
You must be signed in to change notification settings - Fork 87
Closed
Labels
refactorInternal improvementInternal improvementrequires new majorThis would be a breaking changeThis would be a breaking changev25To be done in V25To be done in V25vaadin-popover
Description
Motivation
The vaadin-popover
should set popover="manual"
on the vaadin-popover-overlay
.
Proposed solution
- Keep
vaadin-popover-overlay
in shadow DOM and useexportparts
for::part()
styling - Add slotted
<div slot="overlay">
to be used as arenderer
function / directive content root - Remove copying of the offset custom CSS properties (once the
vaadin-tooltip
is updated) - Remove / adjust
_onGlobalTab
logic for moving focus to the popover content on target Tab
Note
We can also add support for light DOM content in vaadin-popover
instead of renderer
e.g. like this:
<vaadin-popover>
<div slot="overlay">
Popover content
</div>
</vaadin-popover>`
But I'm not sure if we should do it immediately, in theory it can be a future improvement for V25 minors.
jouni
Metadata
Metadata
Assignees
Labels
refactorInternal improvementInternal improvementrequires new majorThis would be a breaking changeThis would be a breaking changev25To be done in V25To be done in V25vaadin-popover