Skip to content

Commit b9064cd

Browse files
christopherthielenmergify[bot]
authored andcommitted
fix(UISrefActive): Avoid reusing the same array reference during setState() call
The component wasn't getting rendered after calling setUiSrefs() because the same array reference was passed in due to the use of removeFrom()
1 parent 97289e7 commit b9064cd

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/components/UISrefActive.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
/** */
66

77
import * as React from 'react';
8-
import { removeFrom } from '@uirouter/core';
98
import { useState, useCallback, useContext, useMemo, cloneElement } from 'react';
109
import * as _classNames from 'classnames';
1110

@@ -89,7 +88,7 @@ export function UISrefActive({ children, className, class: classToApply, exact }
8988
setUiSrefs(uiSrefs => uiSrefs.concat(addedUiSref));
9089
return () => {
9190
parentDeregister();
92-
setUiSrefs(uiSrefs => removeFrom(uiSrefs, addedUiSref));
91+
setUiSrefs(uiSrefs => uiSrefs.filter(x => x !== addedUiSref));
9392
};
9493
},
9594
[parentAddStateInfo]

0 commit comments

Comments
 (0)