TestDataRace: Fix leak (#1081)

abhinav · web-flow · commit 808956abfb1e · 2023-05-07T22:22:42.000-07:00
TestDataRace never calls App.Stop, which can cause a resource leak.
This currently passes because of the implementation detail that
Shutdowner.Shutdown happens to call signalReceivers.Stop
instead of just Shutdown, which may not always be true.
diff --git a/shutdown_test.go b/shutdown_test.go
@@ -138,7 +138,7 @@ func TestDataRace(t *testing.T) {
 		t,
 		fx.Populate(&s),
 	)
-	require.NoError(t, app.Start(context.Background()), "error starting app")
+	defer app.RequireStart().RequireStop()
 
 	const N = 50
 	ready := make(chan struct{}) // used to orchestrate goroutines for Done() and ShutdownOption()

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ func TestDataRace(t *testing.T) {`
`138`	`138`	`t,`
`139`	`139`	`fx.Populate(&s),`
`140`	`140`	`)`
`141`		`- require.NoError(t, app.Start(context.Background()), "error starting app")`
	`141`	`+ defer app.RequireStart().RequireStop()`
`142`	`142`
`143`	`143`	`const N = 50`
`144`	`144`	`ready := make(chan struct{}) // used to orchestrate goroutines for Done() and ShutdownOption()`