Merge pull request #1275 from mpilquist/bugfix/chunk-toarray-underflow

Fixed a bug in Chunk#toArray when the backing type is ByteBufferChunk

Author: mpilquist

.travis.yml

@@ -27,7 +27,7 @@ script:
   - sbt ++$TRAVIS_SCALA_VERSION -Dfile.encoding=UTF8 -Dfs2.test.verbose testJVM
   - sbt ++$TRAVIS_SCALA_VERSION -Dfile.encoding=UTF8 -Dfs2.test.verbose testJS
   - sbt ++$TRAVIS_SCALA_VERSION -Dfile.encoding=UTF8 doc mimaReportBinaryIssues
-  - (test $TRAVIS_SCALA_VERSION == "2.11.12" && sbt ++$TRAVIS_SCALA_VERSION -Dfile.encoding=UTF8 -J-Xms2g -J-Xmx2g docs/tut) || test $TRAVIS_SCALA_VERSION == "2.12.6"
+  - (test $TRAVIS_SCALA_VERSION == "2.11.12" && sbt ++$TRAVIS_SCALA_VERSION -Dfile.encoding=UTF8 -J-Xms2g -J-Xmx2g docs/tut) || test $TRAVIS_SCALA_VERSION == "2.12.7"
 
 after_success:
   - test $PUBLISH == "true" && test $TRAVIS_PULL_REQUEST == "false" && test $TRAVIS_BRANCH == "series/1.0" && sbt +publish

core/shared/src/main/scala/fs2/Chunk.scala

@@ -784,7 +784,7 @@ object Chunk {
       val bs = new Array[C](size)
       val b = duplicate(buf)
       b.position(offset)
-      get(buf, bs, 0, size)
+      get(b, bs, 0, size)
       bs.asInstanceOf[Array[O2]]
     }
 

core/shared/src/main/scala/fs2/concurrent/Queue.scala

@@ -43,9 +43,9 @@ trait Dequeue1[F[_], A] {
   def dequeue1: F[A]
 
   /**
-   * Tries to dequeue a single element. Unlike `dequeue1`, this method does not semantically
-   * block until a chunk is available - instead, `None` is returned immediately.
-   */
+    * Tries to dequeue a single element. Unlike `dequeue1`, this method does not semantically
+    * block until a chunk is available - instead, `None` is returned immediately.
+    */
   def tryDequeue1: F[Option[A]]
 }
 
@@ -56,10 +56,10 @@ trait DequeueChunk1[F[_], G[_], A] {
   def dequeueChunk1(maxSize: Int): F[G[Chunk[A]]]
 
   /**
-   * Tries to dequeue a single chunk of no more than `max size` elements.
-   * Unlike `dequeueChunk1`, this method does not semantically block until a chunk is available -
-   * instead, `None` is returned immediately.
-   */
+    * Tries to dequeue a single chunk of no more than `max size` elements.
+    * Unlike `dequeueChunk1`, this method does not semantically block until a chunk is available -
+    * instead, `None` is returned immediately.
+    */
   def tryDequeueChunk1(maxSize: Int): F[Option[G[Chunk[A]]]]
 }
 

core/shared/src/test/scala/fs2/ChunkProps.scala

@@ -33,8 +33,10 @@ object ChunkProps
   def propToArray[A: ClassTag: Arbitrary, C <: Chunk[A]: Arbitrary] =
     forAll { c: C =>
       c.toArray.toVector shouldBe c.toVector
+      // Do it twice to make sure the first time didn't mutate state
+      c.toArray.toVector shouldBe c.toVector
     }
-    
+
   def propCopyToArray[A: ClassTag: Arbitrary, C <: Chunk[A]: Arbitrary] =
     forAll { c: C =>
       val arr = new Array[A](c.size * 2)

io/src/main/scala/fs2/io/file/file.scala

@@ -7,7 +7,6 @@ import scala.concurrent.duration._
 import java.nio.file.{Path, StandardOpenOption, WatchEvent}
 
 import cats.effect.{Concurrent, ContextShift, Resource, Sync}
-import cats.implicits._
 
 /** Provides support for working with files. */
 package object file {