Add missing error codes (#177)

Author: tommy-mitchell

source/lib/compiler.ts

@@ -33,6 +33,10 @@ const expectErrordiagnosticCodesToIgnore = new Set<DiagnosticCode>([
 	DiagnosticCode.ThisContextOfTypeNotAssignableToMethodOfThisType,
 	DiagnosticCode.ValueOfTypeNotCallable,
 	DiagnosticCode.ExpressionNotCallable,
+	DiagnosticCode.TypeNotAssignableWithExactOptionalPropertyTypes,
+	DiagnosticCode.TypeNotAssignableToParameterWithExactOptionalPropertyTypes,
+	DiagnosticCode.TypeNotAssignableTypeOfTargetWithExactOptionalPropertyTypes,
+	DiagnosticCode.IndexSignatureOnlyPermitsReading,
 	DiagnosticCode.OnlyVoidFunctionIsNewCallable,
 	DiagnosticCode.ExpressionNotConstructable,
 	DiagnosticCode.NewExpressionTargetLackingConstructSignatureHasAnyType,

source/lib/interfaces.ts

@@ -39,6 +39,10 @@ export enum DiagnosticCode {
 	ExpressionNotCallable = 2349,
 	OnlyVoidFunctionIsNewCallable = 2350,
 	ExpressionNotConstructable = 2351,
+	TypeNotAssignableWithExactOptionalPropertyTypes = 2375,
+	TypeNotAssignableToParameterWithExactOptionalPropertyTypes = 2379,
+	TypeNotAssignableTypeOfTargetWithExactOptionalPropertyTypes = 2412,
+	IndexSignatureOnlyPermitsReading = 2542,
 	NoOverloadExpectsCountOfArguments = 2575,
 	ThisContextOfTypeNotAssignableToMethodOfThisType = 2684,
 	PropertyMissingInType1ButRequiredInType2 = 2741,

source/test/fixtures/expect-error/enabled-exact-optional-property-types/index.d.ts

@@ -0,0 +1,6 @@
+export type OptionalProperty = {
+	requiredProp: 'required';
+	optionalProp?: 'optional';
+};
+
+export function setWithOptionalProperty(obj: OptionalProperty): any;

source/test/fixtures/expect-error/enabled-exact-optional-property-types/index.js

@@ -0,0 +1,3 @@
+module.exports.default = (foo, bar) => {
+	return foo + bar;
+};

source/test/fixtures/expect-error/enabled-exact-optional-property-types/index.test-d.ts

@@ -0,0 +1,21 @@
+import {expectError} from '../../../..';
+import {OptionalProperty, setWithOptionalProperty} from '.';
+
+expectError(() => {
+	const obj: OptionalProperty = {
+		requiredProp: 'required',
+		// ts2375 - setting optional property to undefined
+		optionalProp: undefined,
+	};
+});
+
+expectError(setWithOptionalProperty({
+	requiredProp: 'required',
+	// ts2379 - setting optional property to undefined in a parameter
+	optionalProp: undefined,
+}));
+
+const obj: OptionalProperty = { requiredProp: 'required' };
+
+// ts2412 - setting optional property to undefined by access
+expectError(obj.optionalProp = undefined);

source/test/fixtures/expect-error/enabled-exact-optional-property-types/package.json

@@ -0,0 +1,8 @@
+{
+	"name": "foo",
+	"tsd": {
+		"compilerOptions": {
+			"exactOptionalPropertyTypes": true
+		}
+	}
+}

source/test/fixtures/expect-error/values/index.d.ts

@@ -24,3 +24,7 @@ export const triggerSuggestion: {
 	// emit a regular TS2322 error without the "Did you mean..." suggestion.
 	fooOrBar: 'foo' | 'bar';
 };
+
+export type ReadonlyKeys = {
+	readonly [type: string]: any;
+}

source/test/fixtures/expect-error/values/index.test-d.ts

@@ -1,5 +1,5 @@
 import {expectError} from '../../../..';
-import {default as one, atLeastOne, foo, getFoo, HasKey, hasProperty, MyClass, Options, triggerSuggestion} from '.';
+import {default as one, atLeastOne, foo, getFoo, HasKey, hasProperty, MyClass, Options, triggerSuggestion, ReadonlyKeys} from '.';
 
 expectError<string>(1);
 expectError<string>('fo');
@@ -37,3 +37,12 @@ expectError(new hasProperty({name: 'foo'}));
 expectError(() => {
 	triggerSuggestion.fooOrBar = 'fooo';
 })
+
+expectError(() => {
+    const foo: ReadonlyKeys = {
+		bar: 'baz',
+	};
+
+	// ts2542 - trying to modify readonly key
+	foo.bar = 'bar';
+});

source/test/test.ts

@@ -309,6 +309,12 @@ test('expectError for values (noImplicitAny disabled)', async t => {
 	verify(t, diagnostics, []);
 });
 
+test('expectError for values (exactOptionalPropertyTypes enabled)', async t => {
+	const diagnostics = await tsd({cwd: path.join(__dirname, 'fixtures/expect-error/enabled-exact-optional-property-types')});
+
+	verify(t, diagnostics, []);
+});
+
 test('missing import', async t => {
 	const diagnostics = await tsd({cwd: path.join(__dirname, 'fixtures/missing-import')});