review - writer.write returns after save completion

Author: bencmbrook

src/api.ts

@@ -192,7 +192,6 @@ async function save(
     });
     await writer.write(...files);
     await writer.close();
-    await writer.done();
     return;
   }
 

src/zip.ts

@@ -368,19 +368,14 @@ export class PenumbraZipWriter extends EventTarget {
       await this.writer.close();
       this.closed = true;
     }
+    /**
+     * Await completion of the underlying zip stream being written to the sink
+     * @returns Promise that resolves when the sink write completes
+     */
+    await this.pipePromise;
     return size;
   }
 
-  /**
-   * Await completion of the underlying zip stream being written to the sink
-   * @returns Promise that resolves when the sink write completes
-   */
-  async done(): Promise<void> {
-    if (this.pipePromise) {
-      await this.pipePromise;
-    }
-  }
-
   /** Cancel Penumbra zip writer */
   abort(): void {
     if (!this.controller.signal.aborted) {

tests/api.test.ts

@@ -479,7 +479,6 @@ describe('Penumbra API', () => {
       })),
     );
     await writer.close();
-    await writer.done();
     assert.isTrue(
       progressEventFiredAndWorking,
       'zip progress event fired & emitted expected properties',