Skip to content

Commit 1d33f46

Browse files
authored
Revert "Bump otelcontribcol version to v0.106.0-gke.2 (GoogleContainerTools#1369)" (GoogleContainerTools#1376)
This reverts commit 91e1b14. Reason for revert: This change breaks TestOtelCollectorDeployment
1 parent 852ee14 commit 1d33f46

8 files changed

+24
-80
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ HELM_STAGING_DIR := $(OUTPUT_DIR)/third_party/helm
8484
GIT_SYNC_VERSION := v4.2.3-gke.5__linux_amd64
8585
GIT_SYNC_IMAGE_NAME := gcr.io/config-management-release/git-sync:$(GIT_SYNC_VERSION)
8686

87-
OTELCONTRIBCOL_VERSION := v0.106.0-gke.2
87+
OTELCONTRIBCOL_VERSION := v0.102.0-gke.6
8888
OTELCONTRIBCOL_IMAGE_NAME := gcr.io/config-management-release/otelcontribcol:$(OTELCONTRIBCOL_VERSION)
8989

9090
# Directory used for staging Docker contexts.

manifests/base/kustomization.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ resources:
2222
- ../ns-reconciler-base-cluster-role.yaml
2323
- ../root-reconciler-base-cluster-role.yaml
2424
- ../otel-agent-cm.yaml
25-
- ../otel-agent-reconciler-cm.yaml
2625
- ../reconciler-manager-service-account.yaml
2726
- ../reposync-crd.yaml
2827
- ../rootsync-crd.yaml

manifests/otel-agent-cm.yaml

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,24 @@ data:
3232
tls:
3333
insecure: true
3434
processors:
35+
# Attributes processor adds custom configsync metric labels to applicable
36+
# metrics to identify the sync object used to configure this deployment.
37+
#
38+
# Note: configsync.sync.generation is explicitly excluded here, because it
39+
# is high cardinality. So we don't want to send it as a label, only as a
40+
# resource attribute. That way it's only propagated to Prometheus, and not
41+
# Monarch or Cloud Monitoring, which ignore custom resource attributes.
42+
attributes:
43+
actions:
44+
- key: configsync.sync.kind
45+
action: upsert
46+
value: $CONFIGSYNC_SYNC_KIND
47+
- key: configsync.sync.name
48+
action: upsert
49+
value: $CONFIGSYNC_SYNC_NAME
50+
- key: configsync.sync.namespace
51+
action: upsert
52+
value: $CONFIGSYNC_SYNC_NAMESPACE
3553
batch:
3654
# Populate resource attributes from OTEL_RESOURCE_ATTRIBUTES env var and
3755
# the GCE metadata service, if available.
@@ -44,7 +62,7 @@ data:
4462
pipelines:
4563
metrics:
4664
receivers: [opencensus]
47-
processors: [batch, resourcedetection]
65+
processors: [batch, resourcedetection, attributes]
4866
exporters: [opencensus]
4967
telemetry:
5068
logs:

manifests/otel-agent-reconciler-cm.yaml

Lines changed: 0 additions & 69 deletions
This file was deleted.

manifests/templates/otel-collector.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ spec:
101101
# The prometheus transformer appends `_ratio` to gauge metrics: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.86.0/pkg/translator/prometheus/normalize_name.go#L149
102102
# Add the feature gate to enable metric suffix trimming.
103103
- "--feature-gates=-pkg.translator.prometheus.NormalizeName"
104-
- "--feature-gates=-component.UseLocalHostAsDefaultHost"
105104
resources:
106105
limits:
107106
cpu: 1

manifests/templates/reconciler-manager-configmap.yaml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -168,11 +168,10 @@ data:
168168
command:
169169
- /otelcontribcol
170170
args:
171-
- "--config=/conf/otel-agent-reconciler-config.yaml"
171+
- "--config=/conf/otel-agent-config.yaml"
172172
# The prometheus transformer appends `_ratio` to gauge metrics: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.86.0/pkg/translator/prometheus/normalize_name.go#L149
173173
# Add the feature gate to enable metric suffix trimming.
174174
- "--feature-gates=-pkg.translator.prometheus.NormalizeName"
175-
- "--feature-gates=-component.UseLocalHostAsDefaultHost"
176175
securityContext:
177176
allowPrivilegeEscalation: false
178177
readOnlyRootFilesystem: true
@@ -185,7 +184,7 @@ data:
185184
- containerPort: 8888 # Metrics.
186185
protocol: TCP
187186
volumeMounts:
188-
- name: otel-agent-config-reconciler-vol
187+
- name: otel-agent-config-vol
189188
mountPath: /conf
190189
readinessProbe:
191190
httpGet:
@@ -274,9 +273,9 @@ data:
274273
secret:
275274
secretName: git-creds
276275
defaultMode: 288
277-
- name: otel-agent-config-reconciler-vol
276+
- name: otel-agent-config-vol
278277
configMap:
279-
name: otel-agent-reconciler
278+
name: otel-agent
280279
defaultMode: 420
281280
- name: service-account
282281
emptyDir: {}

manifests/templates/reconciler-manager.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ spec:
7171
# The prometheus transformer appends `_ratio` to gauge metrics: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.86.0/pkg/translator/prometheus/normalize_name.go#L149
7272
# Add the feature gate to enable metric suffix trimming.
7373
- "--feature-gates=-pkg.translator.prometheus.NormalizeName"
74-
- "--feature-gates=-component.UseLocalHostAsDefaultHost"
7574
resources:
7675
limits:
7776
cpu: 1

manifests/templates/resourcegroup-manifest.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,6 @@ spec:
231231
- ALL
232232
- args:
233233
- --config=/conf/otel-agent-config.yaml
234-
- --feature-gates=-component.UseLocalHostAsDefaultHost
235234
command:
236235
- /otelcontribcol
237236
env:

0 commit comments

Comments
 (0)