Skip to content

na.rm not defaulted in layer() #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oneilsh opened this issue Feb 3, 2016 · 1 comment
Closed

na.rm not defaulted in layer() #1532

oneilsh opened this issue Feb 3, 2016 · 1 comment

Comments

@oneilsh
Copy link

oneilsh commented Feb 3, 2016

Not sure if this is considered an issue or not, but I noticed that while na.rm recently defaults to FALSE for some stats (035e6ff, 067e096) the layer() function doesn't have a default, resulting in Error: is.logical(na.rm) is not TRUE if params is unspecified.

Just checking to see if this is the intended behavior/will stay that way going forward. (Same with no default for position?)

p <- ggplot() +
  layer(data = diamonds, 
        stat = "bin",
        geom = "bar",
        mapping = aes(x = price),
        position = "identity")
plot(p)
@hadley
Copy link
Member

hadley commented Feb 4, 2016

Fixed in 7d67785

I don't see how position could default to anything other than NULL though. It would be inconsistent with geom and stat

@hadley hadley closed this as completed Feb 4, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants