Skip to content

Commit 7459e41

Browse files
authored
fix!: remove apphub_service_uri from output of simple_bucket (#372)
1 parent 480dedf commit 7459e41

File tree

4 files changed

+14
-15
lines changed

4 files changed

+14
-15
lines changed

docs/upgrading_to_v9.0.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# Upgrading to v9.0
2+
3+
The v9.0 release contains backwards-incompatible changes.
4+
5+
## Replace uses of apphub_service_uri
6+
7+
This release removes apphub_service_uri output. You can replace use of `apphub_service_uri` by forming the desired output as below,
8+
9+
```
10+
{
11+
service_uri = "//storage.googleapis.com/${module.simple_bucket.name}"
12+
service_id = substr(module.simple_bucket.name, 0, 63)
13+
}
14+
```

modules/simple_bucket/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ Functional examples are included in the
6464

6565
| Name | Description |
6666
|------|-------------|
67-
| apphub\_service\_uri | URI in CAIS style to be used by Apphub. |
6867
| bucket | The created storage bucket |
6968
| internal\_kms\_configuration | The intenal KMS Resource. |
7069
| name | Bucket name. |

modules/simple_bucket/metadata.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -166,12 +166,6 @@ spec:
166166
})
167167
defaultValue: {}
168168
outputs:
169-
- name: apphub_service_uri
170-
description: URI in CAIS style to be used by Apphub.
171-
type:
172-
- object
173-
- service_id: string
174-
service_uri: string
175169
- name: bucket
176170
description: The created storage bucket
177171
type:

modules/simple_bucket/outputs.tf

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,3 @@ output "internal_kms_configuration" {
3333
description = "The intenal KMS Resource."
3434
value = var.internal_encryption_config.create_encryption_key ? module.encryption_key[0] : null
3535
}
36-
37-
output "apphub_service_uri" {
38-
value = {
39-
service_uri = "//storage.googleapis.com/${google_storage_bucket.bucket.name}"
40-
service_id = substr(google_storage_bucket.bucket.name, 0, 63)
41-
}
42-
description = "URI in CAIS style to be used by Apphub."
43-
}

0 commit comments

Comments
 (0)