Skip to content

Commit 7f36d7b

Browse files
Move ReportActivity to termux-shared so that other termux plugins can use it too
1 parent b7b12eb commit 7f36d7b

File tree

20 files changed

+36
-36
lines changed

20 files changed

+36
-36
lines changed

app/src/main/AndroidManifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@
102102
android:theme="@style/Theme.AppCompat.Light.DarkActionBar" />
103103

104104
<activity
105-
android:name=".app.activities.ReportActivity"
105+
android:name=".shared.activities.ReportActivity"
106106
android:theme="@style/Theme.AppCompat.TermuxReportActivity"
107107
android:documentLaunchMode="intoExisting"
108108
/>

app/src/main/java/com/termux/app/activities/SettingsActivity.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
import androidx.preference.PreferenceFragmentCompat;
1111

1212
import com.termux.R;
13-
import com.termux.app.models.ReportInfo;
13+
import com.termux.shared.activities.ReportActivity;
14+
import com.termux.shared.models.ReportInfo;
1415
import com.termux.app.models.UserAction;
1516
import com.termux.shared.interact.ShareUtils;
1617
import com.termux.shared.packages.PackageUtils;
@@ -84,7 +85,7 @@ public void run() {
8485
aboutString.append("\n\n").append(TermuxUtils.getDeviceInfoMarkdownString(context));
8586
aboutString.append("\n\n").append(TermuxUtils.getImportantLinksMarkdownString(context));
8687

87-
ReportActivity.startReportActivity(context, new ReportInfo(UserAction.ABOUT, TermuxConstants.TERMUX_APP.TERMUX_SETTINGS_ACTIVITY_NAME, title, null, aboutString.toString(), null, false));
88+
ReportActivity.startReportActivity(context, new ReportInfo(UserAction.ABOUT.getName(), TermuxConstants.TERMUX_APP.TERMUX_SETTINGS_ACTIVITY_NAME, title, null, aboutString.toString(), null, false));
8889
}
8990
}.start();
9091

app/src/main/java/com/termux/app/terminal/TermuxTerminalViewClient.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424
import com.termux.shared.shell.ShellUtils;
2525
import com.termux.shared.terminal.TermuxTerminalViewClientBase;
2626
import com.termux.shared.termux.TermuxConstants;
27-
import com.termux.app.activities.ReportActivity;
28-
import com.termux.app.models.ReportInfo;
27+
import com.termux.shared.activities.ReportActivity;
28+
import com.termux.shared.models.ReportInfo;
2929
import com.termux.app.models.UserAction;
3030
import com.termux.app.terminal.io.KeyboardShortcut;
3131
import com.termux.app.terminal.io.extrakeys.ExtraKeysView;
@@ -660,7 +660,7 @@ public void run() {
660660
if (termuxAptInfo != null)
661661
reportString.append("\n\n").append(termuxAptInfo);
662662

663-
ReportActivity.startReportActivity(mActivity, new ReportInfo(UserAction.REPORT_ISSUE_FROM_TRANSCRIPT, TermuxConstants.TERMUX_APP.TERMUX_ACTIVITY_NAME, title, null, reportString.toString(), "\n\n" + TermuxUtils.getReportIssueMarkdownString(mActivity), false));
663+
ReportActivity.startReportActivity(mActivity, new ReportInfo(UserAction.REPORT_ISSUE_FROM_TRANSCRIPT.getName(), TermuxConstants.TERMUX_APP.TERMUX_ACTIVITY_NAME, title, null, reportString.toString(), "\n\n" + TermuxUtils.getReportIssueMarkdownString(mActivity), false));
664664
}
665665
}.start();
666666
}

app/src/main/java/com/termux/app/utils/CrashUtils.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@
99
import androidx.annotation.Nullable;
1010

1111
import com.termux.R;
12-
import com.termux.app.activities.ReportActivity;
12+
import com.termux.shared.activities.ReportActivity;
1313
import com.termux.shared.notification.NotificationUtils;
1414
import com.termux.shared.file.FileUtils;
15-
import com.termux.app.models.ReportInfo;
15+
import com.termux.shared.models.ReportInfo;
1616
import com.termux.app.models.UserAction;
1717
import com.termux.shared.settings.preferences.TermuxAppSharedPreferences;
1818
import com.termux.shared.settings.preferences.TermuxPreferenceConstants;
@@ -89,7 +89,7 @@ public void run() {
8989

9090
Logger.logDebug(logTag, "The crash log file at \"" + TermuxConstants.TERMUX_CRASH_LOG_FILE_PATH + "\" found. Sending \"" + title + "\" notification.");
9191

92-
Intent notificationIntent = ReportActivity.newInstance(context, new ReportInfo(UserAction.CRASH_REPORT, logTag, title, null, reportString, "\n\n" + TermuxUtils.getReportIssueMarkdownString(context), true));
92+
Intent notificationIntent = ReportActivity.newInstance(context, new ReportInfo(UserAction.CRASH_REPORT.getName(), logTag, title, null, reportString, "\n\n" + TermuxUtils.getReportIssueMarkdownString(context), true));
9393
PendingIntent pendingIntent = PendingIntent.getActivity(context, 0, notificationIntent, PendingIntent.FLAG_UPDATE_CURRENT);
9494

9595
// Setup the notification channel if not already set up

app/src/main/java/com/termux/app/utils/PluginUtils.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,16 @@
1111
import androidx.annotation.Nullable;
1212

1313
import com.termux.R;
14+
import com.termux.shared.activities.ReportActivity;
1415
import com.termux.shared.notification.NotificationUtils;
1516
import com.termux.shared.termux.TermuxConstants;
1617
import com.termux.shared.termux.TermuxConstants.TERMUX_APP.TERMUX_SERVICE;
17-
import com.termux.app.activities.ReportActivity;
1818
import com.termux.shared.logger.Logger;
1919
import com.termux.shared.settings.preferences.TermuxAppSharedPreferences;
2020
import com.termux.shared.settings.preferences.TermuxPreferenceConstants.TERMUX_APP;
2121
import com.termux.shared.settings.properties.SharedProperties;
2222
import com.termux.shared.settings.properties.TermuxPropertyConstants;
23-
import com.termux.app.models.ReportInfo;
23+
import com.termux.shared.models.ReportInfo;
2424
import com.termux.shared.models.ExecutionCommand;
2525
import com.termux.app.models.UserAction;
2626
import com.termux.shared.data.DataUtils;
@@ -159,7 +159,7 @@ public static void processPluginExecutionCommandError(final Context context, Str
159159
reportString.append("\n\n").append(TermuxUtils.getAppInfoMarkdownString(context, true));
160160
reportString.append("\n\n").append(TermuxUtils.getDeviceInfoMarkdownString(context));
161161

162-
Intent notificationIntent = ReportActivity.newInstance(context, new ReportInfo(UserAction.PLUGIN_EXECUTION_COMMAND, logTag, title, null, reportString.toString(), null,true));
162+
Intent notificationIntent = ReportActivity.newInstance(context, new ReportInfo(UserAction.PLUGIN_EXECUTION_COMMAND.getName(), logTag, title, null, reportString.toString(), null,true));
163163
PendingIntent pendingIntent = PendingIntent.getActivity(context, 0, notificationIntent, PendingIntent.FLAG_UPDATE_CURRENT);
164164

165165
// Setup the notification channel if not already set up

app/src/main/res/values/strings.xml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -105,15 +105,6 @@
105105

106106

107107

108-
<!-- Termux Report And ShareUtils -->
109-
<string name="action_copy">Copy</string>
110-
<string name="action_share">Share</string>
111-
112-
<string name="title_share_with">Share With</string>
113-
<string name="title_report_text">Report Text</string>
114-
115-
116-
117108
<!-- Termux File Receiver -->
118109
<string name="title_file_received">Save file in ~/downloads/</string>
119110
<string name="action_file_received_edit">Edit</string>

app/src/main/res/values/styles.xml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,6 @@
4444
</style>
4545

4646

47-
<style name="Theme.AppCompat.TermuxReportActivity" parent="Theme.AppCompat.Light.NoActionBar">
48-
<item name="colorPrimaryDark">#FF0000</item>
49-
</style>
50-
51-
<style name="Toolbar.Title" parent="TextAppearance.Widget.AppCompat.Toolbar.Title">
52-
<item name="android:textSize">14sp</item>
53-
</style>
54-
55-
5647
<style name="TermuxAlertDialogStyle" parent="@android:style/Theme.Material.Light.Dialog.Alert">
5748
<!-- Seen in buttons on alert dialog: -->
5849
<item name="android:colorAccent">#212121</item>

app/src/main/java/com/termux/app/activities/ReportActivity.java renamed to termux-shared/src/main/java/com/termux/shared/activities/ReportActivity.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.termux.app.activities;
1+
package com.termux.shared.activities;
22

33
import androidx.annotation.NonNull;
44
import androidx.appcompat.app.ActionBar;
@@ -14,11 +14,11 @@
1414
import android.view.MenuInflater;
1515
import android.view.MenuItem;
1616

17-
import com.termux.R;
17+
import com.termux.shared.R;
1818
import com.termux.shared.termux.TermuxConstants;
1919
import com.termux.shared.markdown.MarkdownUtils;
2020
import com.termux.shared.interact.ShareUtils;
21-
import com.termux.app.models.ReportInfo;
21+
import com.termux.shared.models.ReportInfo;
2222

2323
import org.commonmark.node.FencedCodeBlock;
2424

app/src/main/java/com/termux/app/models/ReportInfo.java renamed to termux-shared/src/main/java/com/termux/shared/models/ReportInfo.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.termux.app.models;
1+
package com.termux.shared.models;
22

33
import com.termux.shared.markdown.MarkdownUtils;
44
import com.termux.shared.termux.TermuxUtils;
@@ -8,7 +8,7 @@
88
public class ReportInfo implements Serializable {
99

1010
/** The user action that was being processed for which the report was generated. */
11-
public final UserAction userAction;
11+
public final String userAction;
1212
/** The internal app component that sent the report. */
1313
public final String sender;
1414
/** The report title. */
@@ -26,7 +26,7 @@ public class ReportInfo implements Serializable {
2626
/** The timestamp for the report. */
2727
public final String reportTimestamp;
2828

29-
public ReportInfo(UserAction userAction, String sender, String reportTitle, String reportStringPrefix, String reportString, String reportStringSuffix, boolean addReportInfoToMarkdown) {
29+
public ReportInfo(String userAction, String sender, String reportTitle, String reportStringPrefix, String reportString, String reportStringSuffix, boolean addReportInfoToMarkdown) {
3030
this.userAction = userAction;
3131
this.sender = sender;
3232
this.reportTitle = reportTitle;

termux-shared/src/main/res/values/strings.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,13 @@
7474

7575

7676

77+
<!-- ReportActivity -->
78+
<string name="action_copy">Copy</string>
79+
<string name="action_share">Share</string>
80+
<string name="title_report_text">Report Text</string>
81+
82+
83+
7784
<!-- ShareUtils -->
7885
<string name="title_share_with">Share With</string>
7986

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<resources xmlns:android="http://schemas.android.com/apk/res/android">
3+
<style name="Theme.AppCompat.TermuxReportActivity" parent="Theme.AppCompat.Light.NoActionBar">
4+
<item name="colorPrimaryDark">#FF0000</item>
5+
</style>
6+
7+
<style name="Toolbar.Title" parent="TextAppearance.Widget.AppCompat.Toolbar.Title">
8+
<item name="android:textSize">14sp</item>
9+
</style>
10+
</resources>

0 commit comments

Comments
 (0)