chore: streamline GitHub Actions workflow for client generation

- Simplified event types for pull requests and push triggers in the workflow configuration.
- Updated Git user configuration to use global settings for better consistency.
- Enhanced change detection logic before committing and pushing generated client files.
- Removed unnecessary comments and improved overall readability of the workflow file.

Author: cubxxw

.github/workflows/generate-client.yml

@@ -3,37 +3,28 @@ name: Generate Client
 
 on:
   pull_request:
-    types:
-      - opened
-      - synchronize
-  push: # Also consider running on push to main/main to ensure consistency
-    branches:
-      - main # Or your default branch
+    types: [opened, synchronize]
+  push:
+    branches: [main]
 
 permissions:
-  contents: write # Needed for pushing commits on same-repo events
+  contents: write
 
 jobs:
   generate-client:
     runs-on: ubuntu-latest
+
     steps:
-      # 1. Checkout Code - Single step handles both fork and same-repo PRs/pushes
       - name: Checkout Code
         uses: actions/checkout@v4
-        # Fetch depth 0 is needed for accurate diff/commit history if required elsewhere
-        # For pushing back, fetch the specific ref for same-repo PRs
         with:
           ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository && github.head_ref || '' }}
-          # Use a PAT for same-repo events if you need to trigger other workflows
-          # Standard GITHUB_TOKEN is often sufficient for basic pushes
-          # token: ${{ (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && secrets.YOUR_PAT_OR_GITHUB_TOKEN || '' }}
 
-      # 2. Setup Environment
       - name: Setup pnpm
         uses: pnpm/action-setup@v3
         with:
           version: 9.9.0
-      
+
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
@@ -46,34 +37,27 @@ jobs:
         with:
           python-version: "3.10"
 
-      - name: Install uv (Python Package Installer)
-        uses: astral-sh/setup-uv@v1 # Use v1 for stable release
+      - name: Install uv
+        uses: astral-sh/setup-uv@v1
         with:
-          # version: "0.4.15" # Specifying version is optional, can use latest stable
           enable-cache: true
 
-      # 3. Install Dependencies
       - name: Install Frontend Dependencies
         run: pnpm install
         working-directory: frontend
-        
+
       - name: Install Admin Dependencies
         run: pnpm install
         working-directory: admin
 
-      # 安装所有后端依赖项
       - name: Install Backend Dependencies
         run: |
           uv sync
           source .venv/bin/activate
           pip install .
         working-directory: backend
 
-      # 4. Run Generation Script with Error Handling
       - name: Generate Client
-        # Use `uv run` to execute within the backend context if needed,
-        # or just run the script directly if VIRTUAL_ENV isn't strictly necessary
-        # for the script itself (it might just need python)
         run: |
           make generate-client || {
             echo "❌ Failed to run generate-client.sh script."
@@ -87,54 +71,39 @@ jobs:
           SENTRY_DSN: ""
           POSTHOG_API_KEY: ""
           POSTHOG_HOST: ""
-          # VIRTUAL_ENV might not be needed if uv sync --system is used
           VIRTUAL_ENV: .venv
 
-      # 5. Configure Git User
       - name: Configure Git User
         run: |
-          git config --local user.email "github-actions[bot]@users.noreply.github.com"
-          git config --local user.name "github-actions[bot]"
+          git config --global user.email "github-actions@github.com"
+          git config --global user.name "GitHub Actions"
 
-      # 6. Stage Generated Files
-      - name: Stage Generated Client Files
+      - name: Stage Generated Files
         run: |
           git add frontend/app/openapi-client
           git add admin/src/client
 
-      # 7. Handle Changes for Same-Repo Events (Push/PR from same repo)
       - name: Commit and Push Changes (Same Repo)
-        # Run only if it's NOT a PR from a fork
         if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository)
         run: |
-          # Check if there are staged changes
-          if ! git diff --staged --quiet; then
+          BRANCH_NAME="${{ github.head_ref || github.ref_name }}"
+          if ! git diff --quiet || ! git diff --staged --quiet; then
             echo "✅ Changes detected in generated client. Committing and pushing..."
-            # Pull before pushing to avoid conflicts
-            git pull --rebase origin ${{ github.head_ref || github.ref_name }}
+            git add .
+            git pull --rebase origin "$BRANCH_NAME" || true
             git commit -m "ci: ✨ Autogenerate frontend client"
-            git push origin HEAD:${{ github.head_ref || github.ref_name }}
+            git push origin HEAD:"$BRANCH_NAME"
           else
             echo "✅ No changes detected in generated client."
           fi
         env:
-          # GITHUB_TOKEN has write permissions for same-repo events by default
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          # Use a PAT if you need to trigger subsequent workflows:
-          # GITHUB_TOKEN: ${{ secrets.YOUR_PAT_WITH_WRITE_ACCESS }}
 
-      # 8. Handle Changes for Fork PRs (Warn, Don't Fail)
       - name: Check for Uncommitted Changes (Fork PRs)
-        # Run only if it IS a PR from a fork
         if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository
         run: |
-          # Check if there are staged changes that were generated
           if ! git diff --staged --quiet; then
-            echo "⚠️ Changes detected in generated client."
-            echo "➡️ Please run 'bash scripts/generate-client.sh' locally and commit the changes to this PR."
-            # Optionally, use GitHub annotations for better visibility in the PR
             echo "::warning title=Generated Client Changes Detected::Please run 'bash scripts/generate-client.sh' locally and commit the changes to this PR."
-            # DO NOT exit 1 - Allow the workflow to continue
           else
             echo "✅ No changes detected in generated client."
-          fi
+          fi