Merge pull request #66 from telefonicaid/bug/emptyArrayInQueryContextRetrievesAnEmptyEntity

FIX Empty attributes array treated as unexistent

Author: dmoranj

lib/services/contextServer.js

@@ -223,7 +223,7 @@ function handleQuery(req, res, next) {
     }
 
     function completeAttributes(attributes, device, callback) {
-        if (attributes) {
+        if (attributes && attributes.length !== 0) {
             logger.debug(context, 'Handling received set of attributes: %j', attributes);
             callback(null, attributes);
         } else if (device.lazy) {

test/unit/lazy-devices-test.js

@@ -450,6 +450,72 @@ describe('IoT Agent Lazy Devices', function() {
         });
     });
 
+    describe('When a query arrives to the IoT Agent with an empty attributes array', function() {
+        var options = {
+                url: 'http://localhost:' + iotAgentConfig.server.port + '/v1/queryContext',
+                method: 'POST',
+                json: {
+                    entities: [
+                        {
+                            type: 'Light',
+                            isPattern: 'false',
+                            id: 'light1'
+                        }
+                    ],
+                    attributes: []
+                }
+            },
+            sensorData = [
+                {
+                    id: 'light1',
+                    isPattern: false,
+                    type: 'Light',
+                    attributes: [
+                        {
+                            name: 'temperature',
+                            type: 'centigrades',
+                            value: 19
+                        }
+                    ]
+                }
+            ];
+
+        beforeEach(function(done) {
+            nock.cleanAll();
+
+            contextBrokerMock = nock('http://10.11.128.16:1026')
+                .matchHeader('fiware-service', 'smartGondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .post('/NGSI9/registerContext',
+                utils.readExampleFile('./test/unit/contextAvailabilityRequests/registerIoTAgent1.json'))
+                .reply(200,
+                utils.readExampleFile('./test/unit/contextAvailabilityResponses/registerIoTAgent1Success.json'));
+
+            async.series([
+                apply(iotAgentLib.activate, iotAgentConfig),
+                apply(iotAgentLib.register, device1)
+            ], done);
+        });
+
+        it('should return the information of all the attributes', function(done) {
+            var expectedResponse = utils
+                .readExampleFile('./test/unit/contextProviderResponses/queryInformationResponseEmptyAttributes.json');
+
+            iotAgentLib.setDataQueryHandler(function(id, type, attributes, callback) {
+                should.exist(attributes);
+                attributes.length.should.equal(1);
+                attributes[0].should.equal('temperature');
+                callback(null, sensorData[0]);
+            });
+
+            request(options, function(error, response, body) {
+                should.not.exist(error);
+                body.should.eql(expectedResponse);
+                done();
+            });
+        });
+    });
+
     describe('When a context query arrives to the IoT Agent for a type with static attributes', function() {
         var options = {
                 url: 'http://localhost:' + iotAgentConfig.server.port + '/v1/queryContext',