Skip to content

Commit dd8c994

Browse files
danbevMylesBorins
authored andcommitted
deps: cherry-pick b8331cc030 from upstream V8
Original commit message: I believe the paths to the V8 include headers are incorrect. The paths to other sources seem to be relative to the parent directory. When building Node.js I get the following warning on Windows: Warning: Missing input files: deps\v8\src\..\..\include\v8-inspector-protocol.h deps\v8\src\..\..\include\v8-inspector.h This commit updates the two include paths. Bug: Change-Id: I51a057abba61e294e7811ba69db03e283b0bdc3f Reviewed-on: https://chromium-review.googlesource.com/743981 Reviewed-by: Aleksey Kozyatinskiy <[email protected]> Commit-Queue: Aleksey Kozyatinskiy <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#49121} This commit also increments the v8_embedder_string version. PR-URL: nodejs#16900 Fixes: nodejs#16614 Refs: v8/v8@b8331cc Reviewed-By: Ben Noordhuis <[email protected]>
1 parent 55d386c commit dd8c994

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

deps/v8/src/inspector/inspector.gypi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@
3131
'inspector_all_sources': [
3232
'<@(inspector_generated_sources)',
3333
'<(inspector_generated_injected_script)',
34-
'../../include/v8-inspector.h',
35-
'../../include/v8-inspector-protocol.h',
34+
'../include/v8-inspector.h',
35+
'../include/v8-inspector-protocol.h',
3636
'inspector/injected-script.cc',
3737
'inspector/injected-script.h',
3838
'inspector/inspected-context.cc',

0 commit comments

Comments
 (0)