Skip to content

Commit ccb5476

Browse files
committed
Fix syntax error to enable support for python 3.5
Since clients of juptyer_server will need to support py3.5, we should to do the same given JKM's primary application will be jupyter_server. This change fixes the syntax error and adds 3.5 to test matrices.
1 parent b109f0b commit ccb5476

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ python:
33
- 3.8
44
- 3.7
55
- 3.6
6+
- 3.5
67
install:
78
- pip install --upgrade setuptools pip
89
- pip install --upgrade -e .[test] pytest-cov codecov

appveyor.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
environment:
22
matrix:
3+
- CONDA_PY: 35
4+
CONDA_PY_SPEC: 3.5
5+
CONDA_INSTALL_LOCN: "C:\\Miniconda36-x64"
36
- CONDA_PY: 36
47
CONDA_PY_SPEC: 3.6
58
CONDA_INSTALL_LOCN: "C:\\Miniconda36-x64"

jupyter_kernel_mgmt/hl.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ async def __aexit__(self, exc_type, exc_val, exc_tb):
4747

4848

4949
def start_kernel_blocking(
50-
name, *, cwd=None, launch_params=None, finder=None, startup_timeout=60,
50+
name, *, cwd=None, launch_params=None, finder=None, startup_timeout=60
5151
):
5252
"""Start a kernel by kernel type name, return (manager, blocking client)"""
5353
kf = finder or KernelFinder.from_entrypoints()

0 commit comments

Comments
 (0)