Skip to content

Commit 6460bcb

Browse files
Apply suggestions from code review
Co-authored-by: Adam Wathan <[email protected]>
1 parent 1b1d7b9 commit 6460bcb

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10-
### Added
10+
### Changed
1111

12-
- No longer require escaping underscores for CSS variables used in `var()` ([#14776](https://github.com/tailwindlabs/tailwindcss/pull/14776))
12+
- Don't convert underscores in the first argument to `var()` to spaces ([#14776](https://github.com/tailwindlabs/tailwindcss/pull/14776))
1313

1414
### Fixed
1515

packages/tailwindcss/src/candidate.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1080,7 +1080,7 @@ it('should not replace `_` inside of `url()`', () => {
10801080
`)
10811081
})
10821082

1083-
it('should not replace `_` for the first value of `var()`', () => {
1083+
it('should not replace `_` in the first argument to `var()`', () => {
10841084
let utilities = new Utilities()
10851085
utilities.functional('ml', () => [])
10861086

packages/tailwindcss/src/index.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ describe('compiling CSS', () => {
116116
).toMatchSnapshot()
117117
})
118118

119-
test('unescapes underscores to spaces inside arbitrary values expect for url() and first parameter of var()', async () => {
119+
test('unescapes underscores to spaces inside arbitrary values except for `url()` and first argument of `var()`', async () => {
120120
expect(
121121
await compileCss(
122122
css`

packages/tailwindcss/src/utils/decode-arbitrary-value.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import * as ValueParser from '../value-parser'
22
import { addWhitespaceAroundMathOperators } from './math-operators'
33

44
export function decodeArbitraryValue(input: string): string {
5-
// There's definitely no functions in the input, so bail early
5+
// There are definitely no functions in the input, so bail early
66
if (input.indexOf('(') === -1) {
77
return convertUnderscoresToWhitespace(input)
88
}

0 commit comments

Comments
 (0)