From 72ce09214da460bb9132de28163d31973c07b5bb Mon Sep 17 00:00:00 2001 From: zoecarver Date: Sat, 12 Sep 2020 17:44:56 -0700 Subject: [PATCH] [cxx-interop] [NFC] Rename MemberInline.IntBox -> LoadableIntWrapper. --- test/Interop/Cxx/operators/Inputs/member-inline.h | 6 ++++-- .../Cxx/operators/member-inline-irgen.swift | 6 +++--- .../operators/member-inline-module-interface.swift | 4 ++-- .../Cxx/operators/member-inline-silgen.swift | 14 +++++++------- .../Cxx/operators/member-inline-typechecker.swift | 4 ++-- test/Interop/Cxx/operators/member-inline.swift | 6 +++--- 6 files changed, 21 insertions(+), 19 deletions(-) diff --git a/test/Interop/Cxx/operators/Inputs/member-inline.h b/test/Interop/Cxx/operators/Inputs/member-inline.h index 4333f6ef4cb88..0ec5f164ea246 100644 --- a/test/Interop/Cxx/operators/Inputs/member-inline.h +++ b/test/Interop/Cxx/operators/Inputs/member-inline.h @@ -1,9 +1,11 @@ #ifndef TEST_INTEROP_CXX_OPERATORS_INPUTS_MEMBER_INLINE_H #define TEST_INTEROP_CXX_OPERATORS_INPUTS_MEMBER_INLINE_H -struct IntBox { +struct LoadableIntWrapper { int value; - IntBox operator-(IntBox rhs) { return IntBox{.value = value - rhs.value}; } + LoadableIntWrapper operator-(LoadableIntWrapper rhs) { + return LoadableIntWrapper{.value = value - rhs.value}; + } }; #endif diff --git a/test/Interop/Cxx/operators/member-inline-irgen.swift b/test/Interop/Cxx/operators/member-inline-irgen.swift index 169c10d280f06..7395e06f39504 100644 --- a/test/Interop/Cxx/operators/member-inline-irgen.swift +++ b/test/Interop/Cxx/operators/member-inline-irgen.swift @@ -5,7 +5,7 @@ import MemberInline -public func sub(_ lhs: inout IntBox, _ rhs: IntBox) -> IntBox { lhs - rhs } +public func sub(_ lhs: inout LoadableIntWrapper, _ rhs: LoadableIntWrapper) -> LoadableIntWrapper { lhs - rhs } -// CHECK: call [[RES:i32|i64]] [[NAME:@(_ZN6IntBoxmiES_|"\?\?GIntBox@@QEAA\?AU0@U0@@Z")]](%struct.IntBox* {{%[0-9]+}}, {{i32|\[1 x i32\]|i64|%struct.IntBox\* byval align 4}} {{%[0-9]+}}) -// CHECK: define linkonce_odr [[RES]] [[NAME]](%struct.IntBox* %this, {{i32 %rhs.coerce|\[1 x i32\] %rhs.coerce|i64 %rhs.coerce|%struct.IntBox\* byval\(%struct.IntBox\) align 4 %rhs}}) +// CHECK: call [[RES:i32|i64]] [[NAME:@(_ZN18LoadableIntWrappermiES_|"\?\?GLoadableIntWrapper@@QEAA\?AU0@U0@@Z")]](%struct.LoadableIntWrapper* {{%[0-9]+}}, {{i32|\[1 x i32\]|i64|%struct.LoadableIntWrapper\* byval align 4}} {{%[0-9]+}}) +// CHECK: define linkonce_odr [[RES]] [[NAME]](%struct.LoadableIntWrapper* %this, {{i32 %rhs.coerce|\[1 x i32\] %rhs.coerce|i64 %rhs.coerce|%struct.LoadableIntWrapper\* byval\(%struct.LoadableIntWrapper\) align 4 %rhs}}) diff --git a/test/Interop/Cxx/operators/member-inline-module-interface.swift b/test/Interop/Cxx/operators/member-inline-module-interface.swift index b90893ac11e32..c6781ef101caa 100644 --- a/test/Interop/Cxx/operators/member-inline-module-interface.swift +++ b/test/Interop/Cxx/operators/member-inline-module-interface.swift @@ -1,5 +1,5 @@ // RUN: %target-swift-ide-test -print-module -module-to-print=MemberInline -I %S/Inputs -source-filename=x -enable-cxx-interop | %FileCheck %s -// CHECK: struct IntBox { -// CHECK: static func - (lhs: inout IntBox, rhs: IntBox) -> IntBox +// CHECK: struct LoadableIntWrapper { +// CHECK: static func - (lhs: inout LoadableIntWrapper, rhs: LoadableIntWrapper) -> LoadableIntWrapper // CHECK: } diff --git a/test/Interop/Cxx/operators/member-inline-silgen.swift b/test/Interop/Cxx/operators/member-inline-silgen.swift index 3b88723d43149..c9e3c982971a1 100644 --- a/test/Interop/Cxx/operators/member-inline-silgen.swift +++ b/test/Interop/Cxx/operators/member-inline-silgen.swift @@ -2,13 +2,13 @@ import MemberInline -public func sub(_ lhs: inout IntBox, _ rhs: IntBox) -> IntBox { lhs - rhs } +public func sub(_ lhs: inout LoadableIntWrapper, _ rhs: LoadableIntWrapper) -> LoadableIntWrapper { lhs - rhs } -// CHECK: bb0([[SELF:%.*]] : $*IntBox, [[RHS:%.*]] : $IntBox): +// CHECK: bb0([[SELF:%.*]] : $*LoadableIntWrapper, [[RHS:%.*]] : $LoadableIntWrapper): -// CHECK: [[SELFACCESS:%.*]] = begin_access [modify] [static] [[SELF]] : $*IntBox -// CHECK: [[OP:%.*]] = function_ref [[NAME:@(_ZN6IntBoxmiES_|\?\?GIntBox@@QEAA\?AU0@U0@@Z)]] : $@convention(c) (@inout IntBox, IntBox) -> IntBox -// CHECK: apply [[OP]]([[SELFACCESS]], [[RHS]]) : $@convention(c) (@inout IntBox, IntBox) -> IntBox -// CHECK: end_access [[SELFACCESS]] : $*IntBox +// CHECK: [[SELFACCESS:%.*]] = begin_access [modify] [static] [[SELF]] : $*LoadableIntWrapper +// CHECK: [[OP:%.*]] = function_ref [[NAME:@(_ZN18LoadableIntWrappermiES_|\?\?GLoadableIntWrapper@@QEAA\?AU0@U0@@Z)]] : $@convention(c) (@inout LoadableIntWrapper, LoadableIntWrapper) -> LoadableIntWrapper +// CHECK: apply [[OP]]([[SELFACCESS]], [[RHS]]) : $@convention(c) (@inout LoadableIntWrapper, LoadableIntWrapper) -> LoadableIntWrapper +// CHECK: end_access [[SELFACCESS]] : $*LoadableIntWrapper -// CHECK: sil [clang IntBox."-"] [[NAME]] : $@convention(c) (@inout IntBox, IntBox) -> IntBox +// CHECK: sil [clang LoadableIntWrapper."-"] [[NAME]] : $@convention(c) (@inout LoadableIntWrapper, LoadableIntWrapper) -> LoadableIntWrapper diff --git a/test/Interop/Cxx/operators/member-inline-typechecker.swift b/test/Interop/Cxx/operators/member-inline-typechecker.swift index 3b1989865d605..d94c545884c40 100644 --- a/test/Interop/Cxx/operators/member-inline-typechecker.swift +++ b/test/Interop/Cxx/operators/member-inline-typechecker.swift @@ -2,7 +2,7 @@ import MemberInline -var lhs = IntBox(value: 42) -let rhs = IntBox(value: 23) +var lhs = LoadableIntWrapper(value: 42) +let rhs = LoadableIntWrapper(value: 23) let resultPlus = lhs - rhs diff --git a/test/Interop/Cxx/operators/member-inline.swift b/test/Interop/Cxx/operators/member-inline.swift index f3b1e29e26377..67b2f801d0398 100644 --- a/test/Interop/Cxx/operators/member-inline.swift +++ b/test/Interop/Cxx/operators/member-inline.swift @@ -10,9 +10,9 @@ import StdlibUnittest var OperatorsTestSuite = TestSuite("Operators") -OperatorsTestSuite.test("plus") { - var lhs = IntBox(value: 42) - let rhs = IntBox(value: 23) +OperatorsTestSuite.test("LoadableIntWrapper.plus") { + var lhs = LoadableIntWrapper(value: 42) + let rhs = LoadableIntWrapper(value: 23) let result = lhs - rhs