Skip to content

Commit b05f960

Browse files
committed
see what happens if everything runs with server routing
1 parent 3be38e4 commit b05f960

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

packages/kit/src/core/config/index.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ const get_defaults = (prefix = '') => ({
9696
outDir: join(prefix, '.svelte-kit'),
9797
router: {
9898
type: 'pathname',
99-
resolution: 'client'
99+
resolution: 'server'
100100
},
101101
serviceWorker: {
102102
register: true

packages/kit/src/core/config/options.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ const options = object(
263263

264264
router: object({
265265
type: list(['pathname', 'hash']),
266-
resolution: list(['client', 'server'])
266+
resolution: list(['client', 'server'], 'server')
267267
}),
268268

269269
serviceWorker: object({
@@ -283,14 +283,14 @@ const options = object(
283283
false,
284284
(options) => {
285285
if (options.router.resolution === 'server') {
286-
if (options.router.type === 'hash') {
287-
throw new Error('Cannot use router.resolution=server with router.type=hash');
288-
}
289-
if (options.output.bundleStrategy !== 'split') {
290-
throw new Error(
291-
'Cannot use router.resolution=server with output.bundleStrategy=inline or output.bundleStrategy=single'
292-
);
293-
}
286+
// if (options.router.type === 'hash') {
287+
// throw new Error('Cannot use router.resolution=server with router.type=hash');
288+
// }
289+
// if (options.output.bundleStrategy !== 'split') {
290+
// throw new Error(
291+
// 'Cannot use router.resolution=server with output.bundleStrategy=inline or output.bundleStrategy=single'
292+
// );
293+
// }
294294
}
295295
return options;
296296
}

0 commit comments

Comments
 (0)