Skip to content

Commit 9787d4a

Browse files
committed
Deprecate svelte field in package.json
1 parent 7903040 commit 9787d4a

File tree

10 files changed

+20
-46
lines changed

10 files changed

+20
-46
lines changed

packages/package/src/index.js

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -32,27 +32,10 @@ export async function build(config, cwd = process.cwd()) {
3232

3333
const pkg = generate_pkg(cwd, files);
3434

35-
if (!pkg.svelte && files.some((file) => file.is_svelte)) {
36-
// Several heuristics in Kit/vite-plugin-svelte to tell Vite to mark Svelte packages
37-
// rely on the "svelte" property. Vite/Rollup/Webpack plugin can all deal with it.
38-
// See https://github.com/sveltejs/kit/issues/1959 for more info and related threads.
39-
if (pkg.exports['.']) {
40-
const svelte_export =
41-
typeof pkg.exports['.'] === 'string'
42-
? pkg.exports['.']
43-
: pkg.exports['.'].import || pkg.exports['.'].default;
44-
if (svelte_export) {
45-
pkg.svelte = svelte_export;
46-
} else {
47-
console.warn(
48-
'Cannot generate a "svelte" entry point because the "." entry in "exports" is not a string. If you set it by hand, please also set one of the options as a "svelte" entry point\n'
49-
);
50-
}
51-
} else {
52-
console.warn(
53-
'Cannot generate a "svelte" entry point because the "." entry in "exports" is missing. Please specify one or set a "svelte" entry point yourself\n'
54-
);
55-
}
35+
if (pkg.svelte) {
36+
console.warn(
37+
'The "svelte" field in package.json has been deprecated. Please ensure that svelte is a dependency, devDependency, or peerDependency instead.\n'
38+
);
5639
}
5740

5841
write(join(dir, 'package.json'), JSON.stringify(pkg, null, 2));

packages/package/test/fixtures/emitTypes-false/expected/package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,5 @@
99
"./Test.svelte": "./Test.svelte",
1010
"./Test2.svelte": "./Test2.svelte",
1111
".": "./index.js"
12-
},
13-
"svelte": "./index.js"
14-
}
12+
}
13+
}

packages/package/test/fixtures/exports-merge/expected/package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,5 @@
1717
"./Test": "./Test.svelte",
1818
"./package.json": "./package.json"
1919
},
20-
"type": "module",
21-
"svelte": "./index.js"
22-
}
20+
"type": "module"
21+
}

packages/package/test/fixtures/exports-replace/expected/package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,5 @@
99
"import": "./index.js"
1010
},
1111
"./package.json": "./package.json"
12-
},
13-
"svelte": "./Test.svelte"
14-
}
12+
}
13+
}

packages/package/test/fixtures/exports-replace/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,5 @@
88
".": {
99
"import": "./index.js"
1010
}
11-
},
12-
"svelte": "./Test.svelte"
11+
}
1312
}

packages/package/test/fixtures/files-exclude/expected/package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,5 @@
99
"./internal": "./internal/index.js",
1010
"./Test.svelte": "./Test.svelte",
1111
".": "./index.js"
12-
},
13-
"svelte": "./index.js"
14-
}
12+
}
13+
}

packages/package/test/fixtures/javascript/expected/package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,5 @@
1212
"./Test2.svelte": "./Test2.svelte",
1313
"./utils": "./utils.js",
1414
".": "./index.js"
15-
},
16-
"svelte": "./index.js"
17-
}
15+
}
16+
}

packages/package/test/fixtures/resolve-alias/expected/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,5 @@
1212
"./baz": "./baz.js",
1313
"./sub/bar": "./sub/bar.js",
1414
"./sub/foo": "./sub/foo.js"
15-
},
16-
"svelte": "./index.js"
15+
}
1716
}

packages/package/test/fixtures/svelte-kit/expected/package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,5 @@
88
"./package.json": "./package.json",
99
"./Test.svelte": "./Test.svelte",
1010
".": "./index.js"
11-
},
12-
"svelte": "./index.js"
13-
}
11+
}
12+
}

packages/package/test/fixtures/typescript/expected/package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,5 @@
1111
"./Test2.svelte": "./Test2.svelte",
1212
"./utils": "./utils.js",
1313
".": "./index.js"
14-
},
15-
"svelte": "./index.js"
16-
}
14+
}
15+
}

0 commit comments

Comments
 (0)