feat(spark): use core spec bitwise shift functions (#424)

Author: andrew-coleman

spark/src/main/resources/spark.yml

@@ -25,22 +25,3 @@ scalar_functions:
           - name: days
             value: i32
         return: date
-  - name: shift_right
-    description: >-
-      Bitwise (signed) shift right.
-      Params:
-        base – the base number to shift.
-        shift – number of bits to right shift.
-    impls:
-      - args:
-          - name: base
-            value: i64
-          - name: shift
-            value: i32
-        return: i64
-      - args:
-          - name: base
-            value: i32
-          - name: shift
-            value: i32
-        return: i32

spark/src/main/scala/io/substrait/spark/expression/FunctionMappings.scala

@@ -157,7 +157,9 @@ class FunctionMappings {
     s[Lower]("lower"),
     s[Concat]("concat"),
     s[Coalesce]("coalesce"),
+    s[ShiftLeft]("shift_left"),
     s[ShiftRight]("shift_right"),
+    s[ShiftRightUnsigned]("shift_right_unsigned"),
     s[BitwiseAnd]("bitwise_and"),
     s[BitwiseOr]("bitwise_or"),
     s[BitwiseXor]("bitwise_xor"),

spark/src/test/scala/io/substrait/spark/NumericSuite.scala

@@ -47,4 +47,10 @@ class NumericSuite extends SparkFunSuite with SharedSparkSession with SubstraitP
     assertSqlSubstraitRelRoundTrip(
       "select sum(num), avg(num)from (values (2.5), (-0.5)) as table(num)")
   }
+
+  test("bitwise") {
+    assertSqlSubstraitRelRoundTrip(
+      "select shiftleft(num, 2), shiftright(num, 2), shiftrightunsigned(num, 2) from (values (4), (1)) as table(num)"
+    )
+  }
 }