This repository was archived by the owner on Jun 12, 2022. It is now read-only.
Fix status display on symlink projects #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @lefta, congratulation to your first Atom plugin contribution and your changes are looking good :) Thanks for fixing this issue! I'll try to draft a release by this weekend. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #41. When the project is a symbolic link,
TreeViewUI.updateRootswill compare the symbolic link on one hand and the real path on the other hand.I fixed this behavior by using a temporary variable set to the real project path, and use this for repository matching.
This is my first time contributing to an Atom plugin or using coffee script, please excuse any mistake.