Add RLS policy support (#132)

Author: bplunkett-stripe

internal/migration_acceptance_tests/acceptance_test.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"database/sql"
 	"fmt"
+	"reflect"
 	"testing"
 
 	"github.com/google/uuid"
@@ -42,7 +43,9 @@ type (
 	planFactory func(ctx context.Context, connPool sqldb.Queryable, tempDbFactory tempdb.Factory, newSchemaDDL []string, opts ...diff.PlanOpt) (diff.Plan, error)
 
 	acceptanceTestCase struct {
-		name         string
+		name string
+		// roles is a list of roles that should be created before the DDL is applied
+		roles        []string
 		oldSchemaDDL []string
 		newSchemaDDL []string
 
@@ -88,12 +91,16 @@ func (suite *acceptanceTestSuite) runTestCases(acceptanceTestCases []acceptanceT
 			suite.Run("vanilla", func() {
 				suite.runSubtest(tc, tc.vanillaExpectations, nil)
 			})
-			suite.Run("with data packing (and ignoring column order)", func() {
-				suite.runSubtest(tc, tc.dataPackingExpectations, []diff.PlanOpt{
-					diff.WithDataPackNewTables(),
-					diff.WithLogger(log.SimpleLogger()),
+			// Only run the data packing test if there are expectations for it. We should strip out the embedded
+			// data packing tests and make them their own tests to simplify the test suite.
+			if !reflect.DeepEqual(tc.dataPackingExpectations, expectations{}) {
+				suite.Run("with data packing (and ignoring column order)", func() {
+					suite.runSubtest(tc, tc.dataPackingExpectations, []diff.PlanOpt{
+						diff.WithDataPackNewTables(),
+						diff.WithLogger(log.SimpleLogger()),
+					})
 				})
-			})
+			}
 		})
 	}
 }
@@ -106,6 +113,19 @@ func (suite *acceptanceTestSuite) runSubtest(tc acceptanceTestCase, expects expe
 		expects.outputState = tc.newSchemaDDL
 	}
 
+	// Create roles since they are global
+	rootDb, err := sql.Open("pgx", suite.pgEngine.GetPostgresDatabaseDSN())
+	suite.Require().NoError(err)
+	defer rootDb.Close()
+	for _, r := range tc.roles {
+		_, err := rootDb.Exec(fmt.Sprintf("CREATE ROLE %s", r))
+		suite.Require().NoError(err)
+	}
+	defer func() {
+		// This will drop the roles (and attempt to reset other cluster-level state)
+		suite.Require().NoError(pgengine.ResetInstance(context.Background(), rootDb))
+	}()
+
 	// Apply old schema DDL to old DB
 	oldDb, err := suite.pgEngine.CreateDatabase()
 	suite.Require().NoError(err)

internal/migration_acceptance_tests/backwards_compat_cases_test.go

@@ -177,6 +177,6 @@ var backCompatAcceptanceTestCases = []acceptanceTestCase{
 	},
 }
 
-func (suite *acceptanceTestSuite) TestBackCompatAcceptanceTestCases() {
+func (suite *acceptanceTestSuite) TestBackCompatTestCases() {
 	suite.runTestCases(backCompatAcceptanceTestCases)
 }

internal/migration_acceptance_tests/check_constraint_cases_test.go

@@ -568,6 +568,6 @@ var checkConstraintCases = []acceptanceTestCase{
 	},
 }
 
-func (suite *acceptanceTestSuite) TestCheckConstraintAcceptanceTestCases() {
+func (suite *acceptanceTestSuite) TestCheckConstraintTestCases() {
 	suite.runTestCases(checkConstraintCases)
 }

internal/migration_acceptance_tests/column_cases_test.go

@@ -945,6 +945,6 @@ var columnAcceptanceTestCases = []acceptanceTestCase{
 	},
 }
 
-func (suite *acceptanceTestSuite) TestColumnAcceptanceTestCases() {
+func (suite *acceptanceTestSuite) TestColumnTestCases() {
 	suite.runTestCases(columnAcceptanceTestCases)
 }

internal/migration_acceptance_tests/enum_cases_test.go

@@ -126,6 +126,6 @@ var enumAcceptanceTestCases = []acceptanceTestCase{
 	},
 }
 
-func (s *acceptanceTestSuite) TestEnumTestCases() {
-	s.runTestCases(enumAcceptanceTestCases)
+func (suite *acceptanceTestSuite) TestEnumTestCases() {
+	suite.runTestCases(enumAcceptanceTestCases)
 }

internal/migration_acceptance_tests/extensions_cases_test.go

@@ -72,6 +72,6 @@ var extensionAcceptanceTestCases = []acceptanceTestCase{
 	},
 }
 
-func (suite *acceptanceTestSuite) TestExtensionAcceptanceTestCases() {
+func (suite *acceptanceTestSuite) TestExtensionTestCases() {
 	suite.runTestCases(extensionAcceptanceTestCases)
 }

internal/migration_acceptance_tests/function_cases_test.go

@@ -577,6 +577,6 @@ var functionAcceptanceTestCases = []acceptanceTestCase{
 	},
 }
 
-func (suite *acceptanceTestSuite) TestFunctionAcceptanceTestCases() {
+func (suite *acceptanceTestSuite) TestFunctionTestCases() {
 	suite.runTestCases(functionAcceptanceTestCases)
 }

internal/migration_acceptance_tests/index_cases_test.go

@@ -803,6 +803,6 @@ var indexAcceptanceTestCases = []acceptanceTestCase{
 	},
 }
 
-func (suite *acceptanceTestSuite) TestIndexAcceptanceTestCases() {
+func (suite *acceptanceTestSuite) TestIndexTestCases() {
 	suite.runTestCases(indexAcceptanceTestCases)
 }

internal/migration_acceptance_tests/local_partition_index_cases_test.go

@@ -605,6 +605,6 @@ var localPartitionIndexAcceptanceTestCases = []acceptanceTestCase{
 	},
 }
 
-func (suite *acceptanceTestSuite) TestLocalPartitionIndexAcceptanceTestCases() {
+func (suite *acceptanceTestSuite) TestLocalPartitionIndexTestCases() {
 	suite.runTestCases(localPartitionIndexAcceptanceTestCases)
 }

internal/migration_acceptance_tests/named_schema_cases_test.go

@@ -40,6 +40,6 @@ var namedSchemaAcceptanceTestCases = []acceptanceTestCase{
 	},
 }
 
-func (suite *acceptanceTestSuite) TestNamedSchemaAcceptanceTestCases() {
+func (suite *acceptanceTestSuite) TestNamedSchemaTestCases() {
 	suite.runTestCases(namedSchemaAcceptanceTestCases)
 }