From b6d57b45619fc59528fa2c1521b4500f4848a482 Mon Sep 17 00:00:00 2001 From: xeniape Date: Fri, 20 Jun 2025 14:24:06 +0200 Subject: [PATCH 1/2] chore: fix monitoring test --- tests/templates/kuttl/smoke/test_zookeeper.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/templates/kuttl/smoke/test_zookeeper.py b/tests/templates/kuttl/smoke/test_zookeeper.py index f3582f9c..17bb79f9 100755 --- a/tests/templates/kuttl/smoke/test_zookeeper.py +++ b/tests/templates/kuttl/smoke/test_zookeeper.py @@ -64,9 +64,7 @@ def check_monitoring(hosts): url = host + ":9505" response = try_get(url) - if response.ok: - continue - else: + if not response.ok: print("Error for [" + url + "]: could not access monitoring") exit(-1) @@ -81,7 +79,6 @@ def check_monitoring(hosts): else: print("Error for [" + url + "]: missing metrics") exit(-1) - continue else: print("Error for [" + url + "]: could not access monitoring") exit(-1) From 868acc904d84030862f0d13571e3337a643c5458 Mon Sep 17 00:00:00 2001 From: xeniape Date: Mon, 23 Jun 2025 16:01:36 +0200 Subject: [PATCH 2/2] simplify test --- tests/templates/kuttl/smoke/test_zookeeper.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/templates/kuttl/smoke/test_zookeeper.py b/tests/templates/kuttl/smoke/test_zookeeper.py index 17bb79f9..76f5b561 100755 --- a/tests/templates/kuttl/smoke/test_zookeeper.py +++ b/tests/templates/kuttl/smoke/test_zookeeper.py @@ -74,9 +74,7 @@ def check_monitoring(hosts): if response.ok: # arbitrary metric was chosen to test if metrics are present in the response - if "quorum_size" in response.text: - continue - else: + if "quorum_size" not in response.text: print("Error for [" + url + "]: missing metrics") exit(-1) else: