Skip to content

Observation instrumentation incorrectly manages parent observations #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bclozel opened this issue Feb 14, 2023 · 0 comments
Closed

Observation instrumentation incorrectly manages parent observations #611

bclozel opened this issue Feb 14, 2023 · 0 comments
Assignees
Labels
in: core Issues related to config and core support type: bug A general bug
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Feb 14, 2023

The GraphQlObservationInstrumentation is incorrectly setting up the parent observation for both request execution and data fetching observations.

In the case of the request execution, we are not looking into the GraphQL Context for an existing observation - if it exists, it needs to be set as the parent. As for the data fetching observation, we're incorrectly assuming that the parent of all data fetching operations is the request execution one - data fetching operations can be nested and we should only rely on the current observation in the GraphQL context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues related to config and core support type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant