Skip to content

Group Kafka properties that configure the back-off policy #40988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Jun 4, 2024 · 3 comments
Closed

Group Kafka properties that configure the back-off policy #40988

wilkinsona opened this issue Jun 4, 2024 · 3 comments
Assignees
Labels
status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@wilkinsona
Copy link
Member

We have 4 properties that are used to configure the back-off policy:

  • spring.kafka.retry.topic.delay
  • spring.kafka.retry.topic.max-delay
  • spring.kafka.retry.topic.multiplier
  • spring.kafka.retry.topic.random-back-off

There are two other properties at the same level that are not related to the back-off policy:

  • spring.kafka.retry.topic.attempts
  • spring.kafka.retry.topic.enabled

We should group the four back-off related properties to make their purpose clear:

  • spring.kafka.retry.topic.backoff.delay
  • spring.kafka.retry.topic.backoff.max-delay
  • spring.kafka.retry.topic.backoff.multiplier
  • spring.kafka.retry.topic.backoff.random
@wilkinsona wilkinsona added the type: enhancement A general enhancement label Jun 4, 2024
@wilkinsona wilkinsona added this to the 3.x milestone Jun 4, 2024
@travisriegler
Copy link
Contributor

Hello, I would like to work on this issue if you believe it to be a good first contribution for someone to work on. I've taken an initial look at the code and I believe I can do it.

@wilkinsona
Copy link
Member Author

Thanks, @travisriegler, it's all yours.

Just in case you're not already aware, when introducing the new properties, the existing properties should be kept in a deprecated form. You can deprecate them by adding @DeprecatedConfigurationProperty to each deprecated property's getter method.

@scottfrederick
Copy link
Contributor

Closing in favor of #41335

@scottfrederick scottfrederick closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
@scottfrederick scottfrederick added the status: superseded An issue that has been superseded by another label Jul 8, 2024
@scottfrederick scottfrederick removed this from the 3.x milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants